From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#47024: 28.0.50; [feature/native-comp] Warnings from async compilations truncated Date: Fri, 19 Mar 2021 14:16:18 +0000 Message-ID: References: <83sg54p6cl.fsf@gnu.org> <83im5zpu6p.fsf@gnu.org> <83a6rbp36e.fsf@gnu.org> <831rcnp154.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37549"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: eliz@gnu.org To: 47024@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Mar 19 15:18:06 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lNFx0-0009eZ-BR for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 15:18:06 +0100 Original-Received: from localhost ([::1]:36382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lNFwz-0001b6-Cr for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Mar 2021 10:18:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lNFvz-0000vX-BS for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 10:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39179) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lNFvz-00081p-4T for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 10:17:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lNFvy-0002yV-Re for bug-gnu-emacs@gnu.org; Fri, 19 Mar 2021 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Mar 2021 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47024 X-GNU-PR-Package: emacs Original-Received: via spool by 47024-submit@debbugs.gnu.org id=B47024.161616338511375 (code B ref 47024); Fri, 19 Mar 2021 14:17:02 +0000 Original-Received: (at 47024) by debbugs.gnu.org; 19 Mar 2021 14:16:25 +0000 Original-Received: from localhost ([127.0.0.1]:50725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNFvN-0002xO-6g for submit@debbugs.gnu.org; Fri, 19 Mar 2021 10:16:25 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:62900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lNFvL-0002xD-6H for 47024@debbugs.gnu.org; Fri, 19 Mar 2021 10:16:24 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 12JEGIfL012819 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 19 Mar 2021 14:16:18 GMT In-Reply-To: (Andrea Corallo's message of "Fri, 12 Mar 2021 09:04:32 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:202696 Archived-At: Andrea Corallo writes: > Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of > text editors" writes: > >> Eli Zaretskii writes: >> >>>> From: Andrea Corallo >>>> Cc: 47024@debbugs.gnu.org >>>> Date: Wed, 10 Mar 2021 13:12:59 +0000 >>>> >>>> > seq.el:396:16: Warning: `seq-contains' is an obsolete generic function (as of >>>> > 27.1); use `seq-contains-p' instead. >>>> > >>>> > There's an actual newline at the end of the first line, because by >>>> > default we _fill_ the text. >>>> > >>>> > So I think the solution should be to bind (in the sub-process which >>>> > performs the actual compilation) warning-fill-column to a large >>>> > number. >>>> >>>> Nice, is 256 a reasonable number? >>> >>> How about most-positive-fixnum? >> >> Sounds good, fe1c081c38 does that. >> >>>> > Is there a similar issue with error messages? >>>> >>>> Yes, we suffer from the same issue if the Error is emitted with new >>>> lines. >>> >>> But is there a similar variable to bind in that case? fill-column, >>> perhaps? >> >> Dunno, I'll make some tests if we don't get a precise suggestion. > > With 0144764d1d error reporting appears to be working for me. > > I had no problems with line truncations but I had to tweak the way we > are printing them (before we emitted always the full backtrace) so now > we can parse them and report to the user correctly. > > My testcase is to signal and error with a very long message within an > `eval-when-compile' and I see it now reported entirely in the > "*Async-native-compile-log*". > > Please let me know if you have some other suggestion on how to test > this. Hi Eli, is there anything left to be done for this bug? TIA Andrea