all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrea Corallo <akrl@sdf.org>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-devel@gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: Re: master 05d240997a 2/2: Add native-compile-prune-cache command
Date: Fri, 22 Jul 2022 16:50:24 +0000	[thread overview]
Message-ID: <xjfpmhxm6r3.fsf@ma.sdf.org> (raw)
In-Reply-To: <87y1wl9n2n.fsf@gmail.com> (Robert Pluim's message of "Fri, 22 Jul 2022 17:36:16 +0200")

[-- Attachment #1: Type: text/plain, Size: 1324 bytes --]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Fri, 22 Jul 2022 15:14:21 +0000, Andrea Corallo <akrl@sdf.org> said:
>
>     Andrea> Robert Pluim <rpluim@gmail.com> writes:
>     >>>>>>> On Fri, 22 Jul 2022 13:51:04 +0000, Andrea Corallo <akrl@sdf.org> said:
>     >> >> Right. The question is if we want to support such a case (and if so,
>     >> >> exactly how).
>     >> 
>     Andrea> Yep, I really thought the answer was no, at least for now, but I might
>     Andrea> be wrong.
>     >> 
>     Andrea> BTW assuming the answer is no, should we add a load time check with
>     Andrea> associated error or warning for comp.el to gate all these possible
>     Andrea> issues?
>     >> 
>     >> Iʼd lean towards a warning myself (both for loading and for running
>     >> any of the commands inside comp.el)
>
>     Andrea> FWIW I'd probably go just for the load-time warning.  I fear gating
>     Andrea> every function would probably bloat the code for not getting much back.
>
> Something like this (untested) in `normal-top-level'?
>
>     (unless (featurep 'native-compile)
>       (with-eval-after-load 'comp
>         (display-warning 'comp "This emacs does not support native compilation" :warning)))

Yes something similar, wouldn't the attached be simpler?

BR

  Andrea


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Warning-the-user-if-loading-comp-on-a-non-native-cap.patch --]
[-- Type: text/x-diff, Size: 798 bytes --]

From 81bfe715e2137f0572bb17a51bdac3e4f8cd106d Mon Sep 17 00:00:00 2001
From: Andrea Corallo <akrl@sdf.org>
Date: Fri, 22 Jul 2022 18:46:33 +0200
Subject: [PATCH] * Warning the user if loading comp on a non native capable
 Emacs.

* lisp/emacs-lisp/comp.el: Warning the user if loading on a non native
capable Emacs.
---
 lisp/emacs-lisp/comp.el | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 9a635a4776..b9de0289ee 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -28,6 +28,10 @@
 
 ;;; Code:
 
+(unless (featurep 'native-compile)
+  (display-warning 'comp "This emacs does not support native compilation"
+                   :warning))
+
 (require 'bytecomp)
 (require 'cl-extra)
 (require 'cl-lib)
-- 
2.25.1


  parent reply	other threads:[~2022-07-22 16:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165675959499.8421.12451308740112322312@vcs2.savannah.gnu.org>
     [not found] ` <20220702105957.4B7EFC016B5@vcs2.savannah.gnu.org>
2022-07-22  8:51   ` master 05d240997a 2/2: Add native-compile-prune-cache command Robert Pluim
2022-07-22 12:29     ` Stefan Monnier
2022-07-22 12:45     ` Andrea Corallo
2022-07-22 13:01       ` Robert Pluim
2022-07-22 13:51         ` Andrea Corallo
2022-07-22 14:15           ` Robert Pluim
2022-07-22 15:14             ` Andrea Corallo
2022-07-22 15:36               ` Robert Pluim
2022-07-22 15:41                 ` Eli Zaretskii
2022-07-22 15:46                   ` Robert Pluim
2022-07-22 16:18                     ` Eli Zaretskii
2022-07-22 16:41                       ` Robert Pluim
2022-07-22 18:03                         ` Eli Zaretskii
2022-07-22 16:42                       ` Andreas Schwab
2022-07-22 18:04                         ` Eli Zaretskii
2022-07-22 19:49                     ` Stefan Monnier
2022-07-22 16:50                 ` Andrea Corallo [this message]
2022-07-22 18:05                   ` Eli Zaretskii
2022-07-22 18:24                     ` Andrea Corallo
2022-07-22 18:59                       ` Eli Zaretskii
2022-07-22 23:20                         ` Andrea Corallo
2022-07-22 23:41                           ` Stefan Monnier
2022-07-24 17:55                             ` Andrea Corallo
2022-07-22 19:47             ` Stefan Monnier
2022-07-22 19:46       ` Stefan Monnier
2022-07-22 23:17         ` Andrea Corallo
2022-07-22 23:38           ` Stefan Monnier
2022-07-23  6:43             ` Eli Zaretskii
2022-07-23 13:47               ` Stefan Monnier
2022-07-22 19:56     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfpmhxm6r3.fsf@ma.sdf.org \
    --to=akrl@sdf.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.