From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#44676: [PATCH] Support native compilation of packages on install Date: Fri, 20 Nov 2020 20:12:56 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13777"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44676@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 20 21:13:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kgCmM-0003WC-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 21:13:10 +0100 Original-Received: from localhost ([::1]:51094 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kgCmL-0001ML-UB for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Nov 2020 15:13:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kgCmE-0001ME-2Q for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:13:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kgCmD-0000Od-Rc for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:13:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kgCmD-0005Cd-KS for bug-gnu-emacs@gnu.org; Fri, 20 Nov 2020 15:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Nov 2020 20:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 44676-submit@debbugs.gnu.org id=B44676.160590318019992 (code B ref 44676); Fri, 20 Nov 2020 20:13:01 +0000 Original-Received: (at 44676) by debbugs.gnu.org; 20 Nov 2020 20:13:00 +0000 Original-Received: from localhost ([127.0.0.1]:44348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgCmC-0005CO-7V for submit@debbugs.gnu.org; Fri, 20 Nov 2020 15:13:00 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:52465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgCmA-0005CF-2u for 44676@debbugs.gnu.org; Fri, 20 Nov 2020 15:12:58 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 0AKKCuxm011380; Fri, 20 Nov 2020 20:12:56 GMT In-Reply-To: (Stefan Kangas's message of "Fri, 20 Nov 2020 12:03:24 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193797 Archived-At: Stefan Kangas writes: > Andrea Corallo writes: > >>> (native-compile-async "foo.el") >>> (load "foo.el") >> >> The issue is that this does a different thing, if foo.el was never byte >> compiled you will endup with only the non compiled (nor byte or native) >> definitions as the load happes before the async compilation has finished. > > So the eln wouldn't be loaded once it is done compiling, unless you > specify the explicit LOAD parameter? Correct, either you or deferred compilation has to call async-native-compile specifying the load. > If this is the case, I think I > agree with you that we should definitely keep the LOAD parameter. > > However, perhaps we could make the LOAD parameter a simple boolean in > the user-facing `native-compile-async' function? I.e., we hide away > `late' for internal use only. Agree that's probably the best option. Thanks Andrea