From: akrl--- via "Emacs development discussions." <emacs-devel@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [feature/native-comp] breakage on build
Date: Tue, 02 Feb 2021 09:11:52 +0000 [thread overview]
Message-ID: <xjfmtwmsujr.fsf@sdf.org> (raw)
In-Reply-To: <86ft2fjov2.fsf@gmail.com> (Andy Moreton's message of "Tue, 02 Feb 2021 00:27:13 +0000")
Andy Moreton <andrewjmoreton@gmail.com> writes:
> On Sat 30 Jan 2021, akrl--- via "Emacs development discussions." wrote:
>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> Date: Sat, 30 Jan 2021 18:38:10 +0200
>>>> From: Eli Zaretskii <eliz@gnu.org>
>>>> Cc: akrl@sdf.org, emacs-devel@gnu.org
>>>>
>>>> compiling to
>>>> c:/msys64/home/Administrator/emacs-build/build/emacs-28.0.50-snapshot-feature_native-comp-windows/native-lisp/28.0.50-x86_64-w64-mingw32-3459bc949453c7833f94b407f8ee7c17/titdic-cnv-765ac3beca7090ba17f799d9600c18e6-a5dbcc84a969a94717512a079e1cc96a.eln
>>>>
>>>> The name of that file is suspiciously close to the 260-byte limit of
>>>> file-name length that Win32 APIs support. So my guess is that the
>>>> temporary file had a few more characters (like the 6 characters which
>>>> replace the XXXXXX, perhaps?), and that caused the failure.
>>>
>>> Btw, Andrea: why do we need no less than 3 32-character hashes in that
>>> file name? With 26-byte limit on file names that libgccjit can use,
>>> these 96 characters use up almost half of that space, and that will
>>> bite us time and again down the road on MS-Windows. Can we use just
>>> one hash?
>>>
>>
>> Say ATM we have:
>>
>> native-lisp/28.0.50-x86_64-w64-mingw32-HASH1/titdic-cnv-HASH2-HASH3.eln
>>
>> - HASH1 disambiguate triplet, Emacs configuration, version etc. We can
>> say this is disambiguating everything that influence the ABI the eln
>> expects and exposes.
>>
>> - HASH2 is just hashing the full patch of the original source file.
>
> This is unclear. Did you mean the content of the source, or its filename ?
Sorry typo; wanted to write path, so please read filename.
>> - HASH3 is hashing the content of the file.
>>
>> HASH1 is handy because one can remove selectively the eln files of say a
>> previous Emacs version or an old configuration. I often remove all of
>> these folders but the most recent one. That said technically HASH1 and
>> HASH3 could be merged.
>
> This should be done: it is better to simplify the filesystem layout and
> provide some utility functions to help with removing stale cache entries.
Please design and implement such a system, when will be proved it works
well I'm sure these patches will be welcome.
>> HASH2 is handy because there must be within this folder at most one file
>> with each HASH2. IOW recompiling we remove all the other .eln sharing
>> the same HASH2 if present as indeed these files are obsolete.
>
> So if the same source same rebuilt with different eln compile flags then
> only one of them is retained ?
No, HASH2 is not influenced by eln compilation flags.
Andrea
next prev parent reply other threads:[~2021-02-02 9:11 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 10:37 [feature/native-comp] breakage on build Phillip Lord
2021-01-30 13:26 ` akrl--- via Emacs development discussions.
2021-01-30 14:40 ` phillip.lord
2021-01-30 15:01 ` phillip.lord
2021-01-30 16:21 ` Eli Zaretskii
2021-01-30 16:38 ` Eli Zaretskii
2021-01-30 17:06 ` Eli Zaretskii
2021-01-30 17:19 ` phillip.lord
2021-01-30 19:44 ` akrl--- via Emacs development discussions.
2021-01-30 19:58 ` Eli Zaretskii
2021-01-30 20:17 ` akrl--- via Emacs development discussions.
2021-01-31 15:29 ` Eli Zaretskii
2021-02-01 11:01 ` akrl--- via Emacs development discussions.
2021-02-01 15:25 ` Eli Zaretskii
2021-02-01 16:20 ` akrl--- via Emacs development discussions.
[not found] ` <831rdz7mf5.fsf@gnu.org>
2021-02-01 19:01 ` akrl--- via Emacs development discussions.
2021-02-01 19:06 ` Phillip Lord
2021-02-01 19:36 ` Eli Zaretskii
2021-02-01 19:37 ` Stefan Monnier
2021-02-01 20:33 ` akrl--- via Emacs development discussions.
2021-02-02 20:26 ` akrl--- via Emacs development discussions.
2021-02-02 20:29 ` Eli Zaretskii
2021-02-03 12:37 ` akrl--- via Emacs development discussions.
2021-02-03 16:36 ` Phillip Lord
2021-02-03 20:27 ` akrl--- via Emacs development discussions.
2021-02-04 3:31 ` Eli Zaretskii
2021-02-04 14:39 ` Phillip Lord
2021-02-04 15:31 ` Eli Zaretskii
2021-02-04 15:52 ` Phillip Lord
2021-02-04 16:24 ` Eli Zaretskii
2021-02-04 20:24 ` Óscar Fuentes
2021-02-04 20:44 ` Eli Zaretskii
2021-02-04 22:08 ` Óscar Fuentes
2021-02-05 11:50 ` Eli Zaretskii
2021-02-05 14:47 ` Óscar Fuentes
2021-02-05 21:29 ` Phillip Lord
2021-02-05 22:56 ` Óscar Fuentes
2021-02-06 13:15 ` Phillip Lord
2021-02-07 2:52 ` Óscar Fuentes
2021-02-07 18:56 ` Phillip Lord
2021-02-07 19:38 ` Óscar Fuentes
2021-02-07 19:49 ` Eli Zaretskii
2021-02-07 20:33 ` Stefan Monnier
2021-02-07 21:23 ` Óscar Fuentes
2021-02-07 22:23 ` Phillip Lord
2021-02-07 22:21 ` Phillip Lord
2021-02-07 23:38 ` Óscar Fuentes
2021-02-08 12:03 ` Phillip Lord
2021-02-06 7:32 ` Eli Zaretskii
2021-02-04 16:22 ` Andrea Corallo via Emacs development discussions.
2021-02-04 21:07 ` Phillip Lord
2021-02-04 23:32 ` Andrea Corallo via Emacs development discussions.
2021-02-05 10:05 ` Phillip Lord
2021-02-05 11:35 ` Eli Zaretskii
2021-02-05 20:37 ` Phillip Lord
2021-02-05 21:04 ` Eli Zaretskii
2021-02-05 21:50 ` Phillip Lord
2021-02-06 7:45 ` Eli Zaretskii
2021-02-06 12:58 ` Phillip Lord
2021-02-06 13:45 ` Eli Zaretskii
2021-02-07 19:11 ` Phillip Lord
2021-02-08 9:32 ` Andrea Corallo via Emacs development discussions.
2021-02-08 12:08 ` Phillip Lord
2021-02-08 14:28 ` Andrea Corallo via Emacs development discussions.
2021-02-08 14:47 ` Phillip Lord
2021-02-08 15:14 ` Andrea Corallo via Emacs development discussions.
2021-02-08 21:38 ` Stefan Monnier
2021-02-09 8:25 ` Andrea Corallo via Emacs development discussions.
2021-02-09 22:38 ` Phillip Lord
2021-02-10 8:44 ` Andrea Corallo via Emacs development discussions.
2021-02-10 14:04 ` Stefan Monnier
2021-02-10 14:23 ` Andrea Corallo via Emacs development discussions.
2021-02-15 19:17 ` Phillip Lord
2021-02-10 15:16 ` Eli Zaretskii
2021-02-10 20:41 ` Andrea Corallo via Emacs development discussions.
2021-02-11 14:11 ` Eli Zaretskii
2021-02-11 14:51 ` Andrea Corallo via Emacs development discussions.
2021-02-11 15:24 ` Eli Zaretskii
2021-02-11 15:53 ` Andrea Corallo via Emacs development discussions.
2021-02-11 16:11 ` Stefan Monnier
2021-02-11 16:20 ` Andrea Corallo via Emacs development discussions.
2021-02-11 20:52 ` Andrea Corallo via Emacs development discussions.
2021-02-12 6:46 ` Eli Zaretskii
2021-02-10 21:23 ` Phillip Lord
2021-02-11 8:39 ` Andrea Corallo via Emacs development discussions.
2021-02-08 15:25 ` Eli Zaretskii
2021-02-08 15:23 ` Eli Zaretskii
2021-02-07 2:15 ` Óscar Fuentes
2021-02-07 4:14 ` Óscar Fuentes
2021-02-05 11:35 ` Andrea Corallo via Emacs development discussions.
2021-02-05 20:44 ` Phillip Lord
2021-02-05 7:28 ` Eli Zaretskii
2021-01-30 20:21 ` Óscar Fuentes
2021-01-30 22:06 ` Stefan Monnier
2021-01-30 22:23 ` Óscar Fuentes
2021-01-30 22:53 ` Stefan Monnier
2021-02-02 0:27 ` Andy Moreton
2021-02-02 9:11 ` akrl--- via Emacs development discussions. [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-01 18:39 Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfmtwmsujr.fsf@sdf.org \
--to=emacs-devel@gnu.org \
--cc=akrl@sdf.org \
--cc=andrewjmoreton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.