From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Pip Cet <pipcet@gmail.com>
Cc: 46824@debbugs.gnu.org, Aaron Jensen <aaronjensen@gmail.com>
Subject: bug#46824: 28.0.50; nativecomp crash with cl-block/cl-defun
Date: Mon, 01 Mar 2021 17:04:02 +0000 [thread overview]
Message-ID: <xjfmtvmbybh.fsf@sdf.org> (raw)
In-Reply-To: <CAOqdjBer=rGzvmmb6rwsUWC2wVUZghC4mkSDVBxysDDAZVkuhQ@mail.gmail.com> (Pip Cet's message of "Mon, 1 Mar 2021 13:02:03 +0000")
Pip Cet <pipcet@gmail.com> writes:
> On Mon, Mar 1, 2021 at 9:02 AM Andrea Corallo <akrl@sdf.org> wrote:
>> Pip Cet <pipcet@gmail.com> writes:
>> > On Sun, Feb 28, 2021 at 6:13 AM Pip Cet <pipcet@gmail.com> wrote:
>> >> Andrea, is it possible to modify the code so _setjmp is called
>> >> directly rather than through a function pointer?
>> >
>> > This patch, which I hasten to add is not for inclusion and hasn't been
>> > tested against the test suite, might fix the problem (on non-Windows
>> > systems. I'm afraid this problem is something that Windows actually
>> > got right and Unix got wrong...) It does here, experimentally.
>> >
>> > I'd appreciate it if someone could test further.
>>
>> I haven't looked into the patch but the approach sounds like a good idea
>> to me. Can we have the version of the patch you'd like to have included?
>
> Here's the version I'd like to include. This should not cause any new
> test suite failures, just the ones I've been seeing all along. Apart
> from the ABI bump, it should not change anything on WINDOWSNT, which I
> can't test.
>
> Pip
Hi Pip,
thanks for the patch.
Please add to the patch the reported reproducer into
test/src/comp-test-funcs.el exercising it from test/src/comp-tests.el,
you can probably place it after the last reproducer that was added there
(46670).
Thanks
Andrea
next prev parent reply other threads:[~2021-03-01 17:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-28 0:34 bug#46824: 28.0.50; nativecomp crash with cl-block/cl-defun Aaron Jensen
2021-02-28 6:13 ` Pip Cet
2021-02-28 6:36 ` Pip Cet
2021-02-28 23:31 ` Aaron Jensen
2021-03-01 9:02 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-01 13:02 ` Pip Cet
2021-03-01 17:04 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-03-02 9:16 ` Pip Cet
2021-03-02 13:27 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-02 13:27 ` Eli Zaretskii
2021-03-02 14:02 ` Pip Cet
2021-03-02 15:22 ` Eli Zaretskii
2021-03-02 15:42 ` Eli Zaretskii
2021-03-03 19:39 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-03-04 7:22 ` Pip Cet
2021-03-04 7:38 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfmtvmbybh.fsf@sdf.org \
--to=bug-gnu-emacs@gnu.org \
--cc=46824@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=akrl@sdf.org \
--cc=pipcet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.