bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions

bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions

[Andrea Corallo]

[-- Attachment #1: Type: text/plain, Size: 115 bytes --]

Hi all,

shouldn't we declare structure predicates as pure functions?

Proposed patch attached.

Thanks

  Andrea


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-emacs-lisp-cl-macs.el-cl-defstruct-Decl-struct-.patch --]
[-- Type: text/x-diff, Size: 911 bytes --]

From 8382e2078295d6feb4abbe72cf671a61a84fc640 Mon Sep 17 00:00:00 2001
From: Andrea Corallo <akrl@sdf.org>
Date: Wed, 1 Dec 2021 11:23:25 +0100
Subject: [PATCH] * lisp/emacs-lisp/cl-macs.el (cl-defstruct): Decl struct
 predicates as pure

---
 lisp/emacs-lisp/cl-macs.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el
index 1852471bcb..9c9a778f04 100644
--- a/lisp/emacs-lisp/cl-macs.el
+++ b/lisp/emacs-lisp/cl-macs.el
@@ -3050,7 +3050,7 @@ cl-defstruct
                             `(,predicate cl-x))))
     (when pred-form
       (push `(,defsym ,predicate (cl-x)
-               (declare (side-effect-free error-free))
+               (declare (side-effect-free error-free) (pure t))
                ,(if (eq (car pred-form) 'and)
                     (append pred-form '(t))
                   `(and ,pred-form t)))
-- 
2.20.1

bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions

[Lars Ingebrigtsen]

Andrea Corallo <akrl@sdf.org> writes:

> shouldn't we declare structure predicates as pure functions?

I think that's correct?  The predicates take the struct as the argument,
so they seem like pure functions to me.  I've added Stefan to the CCs;
perhaps there's some subtlety here I don't see.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Lars Ingebrigtsen [2021-12-01 21:32:43] wrote:
> Andrea Corallo <akrl@sdf.org> writes:
>> shouldn't we declare structure predicates as pure functions?
> I think that's correct?

Sounds right, yes.


        Stefan

bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions

[Andrea Corallo]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Andrea Corallo <akrl@sdf.org> writes:
>
>> shouldn't we declare structure predicates as pure functions?
>
> I think that's correct?  The predicates take the struct as the argument,
> so they seem like pure functions to me.  I've added Stefan to the CCs;
> perhaps there's some subtlety here I don't see.

Yes we have all conventional predicates as pure, the only difference is
that here the result of the predicate depends also on the global state.

IOW redefining a structure could change the result of a predicate, but
my guess is that we don't want to be robust against that (structs in
general AFAIK are not robust against run-time redefinition).

  Andrea

bug#52220: 29.0.50; [PATCH] Declare struct predicates as pure functions

[Andrea Corallo]

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Lars Ingebrigtsen [2021-12-01 21:32:43] wrote:
>> Andrea Corallo <akrl@sdf.org> writes:
>>> shouldn't we declare structure predicates as pure functions?
>> I think that's correct?
>
> Sounds right, yes.
>
>
>         Stefan

Right, installed as c35c86a353, closing.

Thanks

  Andrea