From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [External] : emacs-28 windows binaries available from alpha Date: Fri, 11 Feb 2022 14:16:37 +0000 Message-ID: References: <834k5d3hbv.fsf@gnu.org> <83o83l1v51.fsf@gnu.org> <83k0e3vox9.fsf@gnu.org> <83fsoruv2u.fsf@gnu.org> <83o83eudgz.fsf@gnu.org> <83ee4atzh5.fsf@gnu.org> <83v8xlst5p.fsf@gnu.org> <83r189skqz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15671"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 11 15:23:11 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nIWpL-0003oC-2I for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Feb 2022 15:23:11 +0100 Original-Received: from localhost ([::1]:35764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nIWpJ-00056S-Mm for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Feb 2022 09:23:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIWjR-0005zY-As for emacs-devel@gnu.org; Fri, 11 Feb 2022 09:17:05 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:57149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nIWjN-0002au-KG; Fri, 11 Feb 2022 09:17:04 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 21BEGcE4019558 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 11 Feb 2022 14:16:38 GMT In-Reply-To: <83r189skqz.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Feb 2022 13:31:00 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286165 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org >> Date: Fri, 11 Feb 2022 09:21:52 +0000 >> >> Andrea Corallo writes: >> >> > Eli Zaretskii writes: >> >> [...] >> >> >>> Anyway I was thinking if it wouldn't be correct to emit also a warning >> >>> if libgccjit is not available. This condition could prevent some >> >>> package to work as expected (ex evil-mode IIRC) so might be worth to >> >>> inform the user that and emacs compiled with native-comp is being run >> >>> without libgccjit being available. >> >> >> >> I'm not sure I see the usefulness of such a warning. If Emacs works >> >> correctly regardless, the warning could annoy. So I tend to think we >> >> should introduce the warning only if enough users complain that Emacs >> >> silently does something they'd prefer to know about. >> > >> > I think it might be useful for two reasons: >> > >> > 1- let the user know that a native compiled Emacs is being run without >> > access to libgccjit, not only it might not function as expected but >> > most likely I guess that if the user compiled a native compiled Emacs >> > he wants to have it working with native code. So in general I guess >> > it might be informative. >> > >> > 2- help us identifying the issue when a bug is opened because of it, if >> > we suspect that's the problem we can ask the user to have a look to >> > the warnings. >> > >> > But indeed I'm not sure it's worth of so I asked. >> > >> > An alternative to point two would be having a trace of this in M-x >> > report-emacs-bug. >> >> Thinking about I think this might be a good idea anyway. > > I agree. Would you mind proposing a patch? Sure, something like: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-mail-emacsbug.el-report-emacs-bug-Report-libgcc.patch >From ffa9772fa5b04f916d6b49668dbd93b1743f6c18 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Fri, 11 Feb 2022 15:00:57 +0100 Subject: [PATCH] * lisp/mail/emacsbug.el (report-emacs-bug): Report libgccjit status. --- lisp/mail/emacsbug.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index f5559e39f6..759d8c11b5 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -304,6 +304,9 @@ report-emacs-bug (emacs-bug--system-description) (insert "Configured features:\n" system-configuration-features "\n\n") (fill-region (line-beginning-position -1) (point)) + (when (and (featurep 'native-compile) + (null (native-comp-available-p))) + (insert "NATIVE_COMP present but libgccjit not available\n\n")) (insert "Important settings:\n") (mapc (lambda (var) -- 2.20.1 --=-=-= Content-Type: text/plain The output (if necessary) is placed after NATIVE_COMP feature is mentioned, ex: ==================== Configured using: 'configure --without-x --with-native-compilation' Configured features: DBUS GMP GNUTLS LIBSELINUX MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER SECCOMP SOUND THREADS XIM ZLIB NATIVE_COMP present but libgccjit not available Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix ==================== Not sure if we like to place it elsewhere and/or if we have a better message to be displayed. Thanks Andrea --=-=-=--