From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Emacs segfaults when handling wrong_type_argument backtrace Date: Thu, 30 Mar 2023 18:51:22 +0000 Message-ID: References: <2c65531c-2d9c-3c1d-bc2a-5666a7de0a38@sft.lol> <83zg7u6cs3.fsf@gnu.org> <838rfe5y68.fsf@gnu.org> <6178cb5d-e31a-0851-8dbf-cb7be08e8542@sft.lol> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31032"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Jonas Jelten Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Mar 30 20:52:12 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1phxNc-0007nH-Cq for ged-emacs-devel@m.gmane-mx.org; Thu, 30 Mar 2023 20:52:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phxMv-0007TE-FD; Thu, 30 Mar 2023 14:51:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phxMu-0007Ss-Bk for emacs-devel@gnu.org; Thu, 30 Mar 2023 14:51:28 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phxMs-0001pF-8S; Thu, 30 Mar 2023 14:51:27 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.16.1/8.14.5) with ESMTPS id 32UIpLxu008007 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 30 Mar 2023 18:51:22 GMT In-Reply-To: <6178cb5d-e31a-0851-8dbf-cb7be08e8542@sft.lol> (Jonas Jelten's message of "Thu, 30 Mar 2023 18:41:50 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304881 Archived-At: Jonas Jelten writes: > On 2023-03-30 12:30, Eli Zaretskii wrote: >>> From: Andrea Corallo >>> Cc: Jonas Jelten , emacs-devel@gnu.org >>> Date: Thu, 30 Mar 2023 09:36:25 +0000 >>> >>> Eli if we want to avoid spurious bug reports due to stale eln-cache we >>> can also increment ABI_VERSION in comp.c. Not sure is something we want >>> to do tho. Please let me know if you think is appropriate in this case. >> I don't think we need to increment ABI_VERSION to avoid bug reports, >> no. Yes, that places additional burden on my and your shoulders >> (perhaps mainly on yours), but bumping the ABI_VERSION has its own >> downsides (e.g., it requires recompilation of all the preloaded >> files), and I don't think this is justified. People who track >> development versions and use that for production sessions will have to >> be prepared to clean up their eln-cache from time to time, when >> changes like this one are made. >> > > After clearing the cache it seems to work, thanks, that was easy. > I assumed that changes in the abi would result in a version bump :) It results in Emacs changing the directory name of the eln under eln-cache, this way Emacs would discard all the other elns and produce new ones. We usually do that when we change something low level in an incompatible way in the eln format. I agree with Eli we should not use that for cases when a bug might have produced miscompiled elns. BR Andrea