From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#42761: 28.0.50; [feature/native-comp] allow customizing command line/driver options? Date: Wed, 19 Aug 2020 15:41:33 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7142"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 42761@debbugs.gnu.org To: Andreas Fuchs Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 19 17:42:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8QE5-0001hl-VU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Aug 2020 17:42:09 +0200 Original-Received: from localhost ([::1]:34414 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8QE5-000648-1L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 Aug 2020 11:42:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8QDy-00063L-PK for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 11:42:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8QDy-0002hd-Fz for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 11:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8QDy-0007iQ-EB for bug-gnu-emacs@gnu.org; Wed, 19 Aug 2020 11:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Aug 2020 15:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42761 X-GNU-PR-Package: emacs Original-Received: via spool by 42761-submit@debbugs.gnu.org id=B42761.159785169929629 (code B ref 42761); Wed, 19 Aug 2020 15:42:02 +0000 Original-Received: (at 42761) by debbugs.gnu.org; 19 Aug 2020 15:41:39 +0000 Original-Received: from localhost ([127.0.0.1]:40789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8QDb-0007ho-Cg for submit@debbugs.gnu.org; Wed, 19 Aug 2020 11:41:39 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:63714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8QDZ-0007hc-9U for 42761@debbugs.gnu.org; Wed, 19 Aug 2020 11:41:38 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 07JFfXlx008597; Wed, 19 Aug 2020 15:41:33 GMT In-Reply-To: (Andreas Fuchs's message of "Wed, 19 Aug 2020 10:37:24 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185629 Archived-At: Andreas Fuchs writes: > Thanks for the notes - I've pushed an updated version that includes > the (hopefully) corrected #if / #pragma usage to remain compatible on > windows, broke the long line & resolved the merge conflict against > the latest HEAD of feature/native-comp. > > I also just got word from the FSF that my copyright assignment for > GNU Emacs is completed (and received the countersigned assignment > papers as PDF) - if the patch looks good to you, I think legally > you're ok to merge (-: Hi Andreas, Super thanks! I've rebased your branched, did some minor changes (broke two long lines and squashed two commits). I pushed it in scratch/native-comp-gcc-driver-options as I was thinking: Okay if the libgccjit feature is not available we raise an error, but how the user is supposed to test for this feature without compiling? 'comp-libgccjit-version' starts working only if gcc_jit_version_major is available otherwise return nil, and I added gcc_jit_version_major into GCC10 :/ We need to offer a way to the user to check for that before going for compilation. The only idea I've at the moment is that we expose a function to set these instead of using 'comp-native-driver-options'. Any thoughts? Andrea -- akrl@sdf.org