all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 48578@debbugs.gnu.org
Subject: bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time
Date: Sat, 29 May 2021 07:02:45 +0000	[thread overview]
Message-ID: <xjfim32kooa.fsf@sdf.org> (raw)
In-Reply-To: <83tumo8f4f.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 27 May 2021 16:45:20 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: 48578@debbugs.gnu.org
>> Date: Thu, 27 May 2021 11:57:22 +0000
>> 
>> >   . why do you use Fexpand_file_name _after_ realpath? shouldn't we
>> >     call it before realpath instead?
>> 
>> Right that's correct.
>> 
>> >   . we need to encode the file name before passing it to realpath, and
>> >     decode the result, right?
>> 
>> Correct
>> 
>> >   . realpath could potentially return NULL, and we should check for
>> >     that, and return the result of Fexpand_file_name if it does
>> 
>> Of course
>> 
>> >   . we don't need to support remote files here via file-handlers,
>> >     right?
>> 
>> Correct, so far we do not support it.
>> 
>> > If you agree with the above, I will prepare a proper patch and install
>> > it, including the necessary changes for WINDOWSNT.
>> 
>> Agreed, thanks.
>
> Thanks, I installed a fix along these lines, please review and
> comment.

Hi Eli,

it looks good to me.

Thanks for fixing this.

  Andrea

 





  reply	other threads:[~2021-05-29  7:02 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-22  7:20 bug#48578: 28.0.50; Native-compiled files of some preloaded files not loaded at dump time Eli Zaretskii
2021-05-24  6:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-24  7:30   ` Eli Zaretskii
2021-05-24  7:47     ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-24  8:10       ` Eli Zaretskii
2021-05-24  8:48         ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-24 16:22           ` Eli Zaretskii
2021-05-25 12:34             ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 13:02               ` Eli Zaretskii
2021-05-25 13:18                 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-25 13:22                   ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-26 13:43                     ` Eli Zaretskii
2021-05-27 11:57                       ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-27 13:45                         ` Eli Zaretskii
2021-05-29  7:02                           ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-05-29  8:57                             ` Eli Zaretskii
2021-05-25 18:13                   ` Basil L. Contovounesios
2021-05-25 18:15                     ` Eli Zaretskii
2021-05-25 18:31                       ` Basil L. Contovounesios

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfim32kooa.fsf@sdf.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=48578@debbugs.gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.