From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] [WIP] Port feature/native-comp to Windows. Date: Tue, 12 May 2020 18:21:57 +0000 Message-ID: References: <5eb5b953.1c69fb81.a67ce.a764@mx.google.com> <83lfm1hc91.fsf@gnu.org> <83wo5lds87.fsf@gnu.org> <83lflzd8es.fsf@gnu.org> <83ftc7d4zu.fsf@gnu.org> <83blmvd2if.fsf@gnu.org> <833686d08r.fsf@gnu.org> <83eerp852g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="26635"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Nicolas =?utf-8?Q?B=C3=A9rtolo?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 12 20:24:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jYZa0-0006pg-6W for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 20:24:36 +0200 Original-Received: from localhost ([::1]:34732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jYZZz-0008Sn-9W for ged-emacs-devel@m.gmane-mx.org; Tue, 12 May 2020 14:24:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38838) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYZXf-0005Pw-Bb for emacs-devel@gnu.org; Tue, 12 May 2020 14:22:11 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:57920) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jYZXd-0004Il-MB; Tue, 12 May 2020 14:22:10 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04CILvRU017020 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 12 May 2020 18:21:57 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04CILvbP002368; Tue, 12 May 2020 18:21:57 GMT In-Reply-To: ("Nicolas =?utf-8?Q?B=C3=A9rtolo=22's?= message of "Tue, 12 May 2020 14:25:05 -0300") Received-SPF: pass client-ip=205.166.94.20; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/12 14:21:58 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:250013 Archived-At: Nicolas B=C3=A9rtolo writes: >> libdl exists only in MinGW64, I think. > >> Why do you need it? is it because the code uses dlopen/dlsym >> somewhere? > > The code uses `dynlib_open` and `dynlib_sym` which are implemented using = libdl > in Posix systems. The original libgccjit uses it to implement the > `compile_to_memory` function that we do not use. The version of libgccjit= I am > using implements that feature using native Windows functions, so libdl is= not > necessary. > > I don't think we can remove it because that part of the code runs only wh= en the > platform is not Mingw, and in that case libdl is necessary. > >> I think it's good to #undef each symbol before defining it. > > Fixed in the new patch. Hi Nicolas, I think would be handy to have 'native-comp-available-p' always defined also when compiling without the native compiler. Similarly to what we have for gnutls-available-p and libxml-available-p. +static bool +load_gccjit_if_necessary(bool mandatory) ^^^ space here +{ +#ifdef WINDOWSNT + if (!gccjit_initialized) + { + Lisp_Object status; + gccjit_initialized =3D init_gccjit_functions (); + Also I think gccjit_initialized should be declared be static inside load_gccjit_if_necessary given should and is used only there. Thanks Andrea --=20 akrl@sdf.org