From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Thu, 18 Feb 2021 21:56:47 +0000 Message-ID: References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39734"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 18 22:57:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lCrIO-000ACv-7b for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 22:57:12 +0100 Original-Received: from localhost ([::1]:34356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCrIN-0005OO-7y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 18 Feb 2021 16:57:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39848) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCrIE-0005Nx-0K for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36763) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lCrID-0007H2-OM for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lCrID-0000SH-MU for bug-gnu-emacs@gnu.org; Thu, 18 Feb 2021 16:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Feb 2021 21:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.16136854121732 (code B ref 43725); Thu, 18 Feb 2021 21:57:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 18 Feb 2021 21:56:52 +0000 Original-Received: from localhost ([127.0.0.1]:48309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCrI4-0000Rs-0i for submit@debbugs.gnu.org; Thu, 18 Feb 2021 16:56:52 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:61443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lCrI1-0000Rh-HC for 43725@debbugs.gnu.org; Thu, 18 Feb 2021 16:56:50 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11ILulDS016007 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 18 Feb 2021 21:56:48 GMT In-Reply-To: <831rdjd95w.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Feb 2021 22:06:51 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200292 Archived-At: Eli Zaretskii writes: [...] > This should have a big FIXME, since it means the name of the DLL is in > two different places, and if we need to support a differently-named > DLL, we are in trouble: Done with 805cae572a. > +#ifdef WINDOWSNT > + /* We may need to load libgccjit when dumping before term/w32-win.el > + defines `dynamic-library-alist`. This will fail if that variable > + is empty, so add libgccjit-0.dll to it. */ > + if (will_dump_p ()) > + Vdynamic_library_alist = list1 (list2 (Qgccjit, > + build_string ("libgccjit-0.dll"))); > > Is there a more elegant way of resolving this difficulty? I've no precise idea. I guess `dynamic-library-alist` should be initialized before any compilation can be triggered, not sure how easy is that, is also something I can't test and as a consequence develop. > This lacks the ENCODE_FILE part: > > + char *fname = SSDATA (concat2 (Vinvocation_directory, > + XCAR (comp_u->file))); > + FILE *file; > + if ((file = fopen (fname, "r"))) > > And why are you using fopen instead of emacs_fopen? 2110a3faf7 fix both suggestons. Thanks Andrea