From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: A modern-mode? Date: Tue, 15 Sep 2020 18:36:53 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30478"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 15 20:37:57 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIFq1-0007qt-LV for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 20:37:57 +0200 Original-Received: from localhost ([::1]:51736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIFq0-0006m4-Kj for ged-emacs-devel@m.gmane-mx.org; Tue, 15 Sep 2020 14:37:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIFp6-0005i6-Ak for emacs-devel@gnu.org; Tue, 15 Sep 2020 14:37:00 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:62518) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIFp4-0005cR-7J for emacs-devel@gnu.org; Tue, 15 Sep 2020 14:37:00 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 08FIarhn028975; Tue, 15 Sep 2020 18:36:53 GMT In-Reply-To: (Stefan Monnier's message of "Tue, 15 Sep 2020 11:08:53 -0400") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/15 12:47:44 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255781 Archived-At: Stefan Monnier writes: > Hi Andrea, > > Any chance you could turn it into a custom-theme? > > AFAIK most of your minor-mode could be turned into a theme fairly > easily, so what I'm asking is for you try and do the extra work to cover > the remaining non-trivial part (e.g. the key-bindings). > > Part of the difference between a minor mode and a custom theme is that > a custom theme is more declarative, with consequences such as the fact > that a user can enable your hypothetical "modern theme" but with > `fido-mode` disabled, and it won't have the effect of "enabling and then > disabling" `fido-mode` (e.g. running `fido-mode-hook` twice along the > way). Sounds like is what we want. Happy to have a look into this direction. > I'm mostly interested in pushing the limits of what can be done with > custom themes, so try to keep an eye on what generic/infrastructure > changes would make a "modern theme" easier to write cleanly. > >> I had a look but for now I gave-up on the idea of picking up a dark mode >> to enable as is not so easy. > > I thought setting the foreground and the background of the `default` > face is all it takes (it should change the frame-background-mode and > thus cause all other faces to choose their dark-background alternative). > What problem did you encounter? Sorry I wasn't clear, I was not referring to a technical difficulty. All I did was just having a look to the dark themes we have in Emacs core and could not find one that fully convinced me. Wombat and tango-dark are not bad but modus-vivendi has maybe the best set of colors, OTOH I think this last IMO has a little too much contrast (probably because focus on accessibility). One thing I noticed is that tool and scroll bar don't change color (I'm testing with GTK). If this an Emacs limitation is not very good as the aesthetic outcome with a dark theme IMO is not optimal (say pretty bad). That said I think this should enable some dark setting so I'll look into how to proceed (suggestions very welcome on this too :). Andrea