From: Andrea Corallo <akrl@sdf.org>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Eli Zaretskii <eliz@gnu.org>,
62537@debbugs.gnu.org,
Pedro Andres Aranda Gutierrez <paaguti@gmail.com>
Subject: bug#62537: Error compiling emacs master with native compilation activated
Date: Wed, 05 Apr 2023 21:12:09 +0000 [thread overview]
Message-ID: <xjffs9ehw46.fsf@ma.sdf.org> (raw)
In-Reply-To: <8CD7FA80-0E05-4112-A063-8F49F6A28CD4@acm.org> ("Mattias Engdegård"'s message of "Wed, 5 Apr 2023 22:51:01 +0200")
Mattias Engdegård <mattiase@acm.org> writes:
> 5 apr. 2023 kl. 19.19 skrev Andrea Corallo <akrl@sdf.org>:
>
>> As we suspected was a bug in the native compiler limplification pass
>> triggered by the new LAP emitted.
>>
>> fa669c4b17c fixes bootstrap --with-native-compilation=aot here and adds
>> a test, is now pushed to master. In 29 the bug never showed up
>> (probably because the new LAP tweak is not it) so I guess it's better to
>> leave the code as it is.
>
> Nice! So the bug was that we optimised away switches where all jump targets are the same, without considering the fall-through case?
Hi Mattias,
yep that's correct :)
> (Perhaps we should do something like that in the LAP optimiser. Wonder how common the opportunity is though.)
Yeah might be a good idea even if I don't know how common this condition
is. (We might count how many times `comp-jump-table-optimizable' returns
t in an aot build tho to get an idea).
> By the way, the bulk of `comp-jump-table-optimizable` should be equivalent to something like
>
> (apply #'= (hash-table-values jmp-table))
>
> which is arguably clearer and definitely shorter.
True but with the downside that it conses. I'll think about if I want
to change it, thanks for the neat suggestion tho :)
Best Regards
Andrea
next prev parent reply other threads:[~2023-04-05 21:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 7:18 bug#62537: Error compiling emacs master with native compilation activated Pedro Andres Aranda Gutierrez
2023-03-30 8:50 ` Eli Zaretskii
2023-03-30 9:28 ` Andrea Corallo
2023-03-30 9:59 ` Pedro Andres Aranda Gutierrez
2023-03-30 10:37 ` Mattias Engdegård
2023-03-30 13:35 ` Andrea Corallo
2023-03-31 10:26 ` Andrea Corallo
2023-03-31 15:14 ` Mattias Engdegård
2023-04-05 17:19 ` Andrea Corallo
2023-04-05 20:51 ` Mattias Engdegård
2023-04-05 21:12 ` Andrea Corallo [this message]
2023-04-05 21:46 ` Mattias Engdegård
2023-04-06 10:42 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjffs9ehw46.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=62537@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mattiase@acm.org \
--cc=paaguti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.