bug#48021: comp.el cannot be loaded without native compilation

bug#48021: comp.el cannot be loaded without native compilation

[Glenn Morris]

Package: emacs
Version: 28.0.50

At b7c22fab7d, in a default build:

./src/emacs -Q -l ./lisp/emacs-lisp/comp.el

   memq: Symbol's value as variable is void: comp-ctxt

(Presumably it works if --with-native-compilation is used.)

This causes test failures for custom tests, and multiple failures for
comp-cstr-tests (perhaps those should be tagged :nativecomp, I don't know.)

Ref eg https://hydra.nixos.org/build/142074384

bug#48021: comp.el cannot be loaded without native compilation

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Glenn Morris <rgm@gnu.org> writes:

> Package: emacs
> Version: 28.0.50
>
> At b7c22fab7d, in a default build:
>
> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>
>    memq: Symbol's value as variable is void: comp-ctxt
>
> (Presumably it works if --with-native-compilation is used.)
>
> This causes test failures for custom tests, and multiple failures for
> comp-cstr-tests (perhaps those should be tagged :nativecomp, I don't know.)
>
> Ref eg https://hydra.nixos.org/build/142074384

Hi Glenn,

with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
please let me know if this is sufficient for the case you are testing.

Thanks

  Andrea

bug#48021: comp.el cannot be loaded without native compilation

[Glenn Morris]

Andrea Corallo wrote:

>> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>>
>>    memq: Symbol's value as variable is void: comp-ctxt

> with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
> please let me know if this is sufficient for the case you are testing.

Thanks. comp-cstr-test-70 is still failing for me.

The issue about comp.el being unloadable in builds without native
compilation remains (and hence test-custom-deps still fails).

I believe that in general, .el files should always be loadable, they
should just do nothing if not applicable.

For example, C-h f completion can try to load comp.el.

bug#48021: comp.el cannot be loaded without native compilation

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Glenn Morris <rgm@gnu.org> writes:

> Andrea Corallo wrote:
>
>>> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>>>
>>>    memq: Symbol's value as variable is void: comp-ctxt
>
>> with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
>> please let me know if this is sufficient for the case you are testing.
>
> Thanks. comp-cstr-test-70 is still failing for me.

Could you share the invocation you are using? I'm asking cause here on
449045b2a6 I see this passing.

>
> The issue about comp.el being unloadable in builds without native
> compilation remains (and hence test-custom-deps still fails).

I didn't know about the test-custom-deps, I'll have a look.

> I believe that in general, .el files should always be loadable, they
> should just do nothing if not applicable.
>
> For example, C-h f completion can try to load comp.el.

We should load comp.el only on native compiled instances, if this is not
the case could you point me out exactly where we do this so I can have a
look?

Thanks

  Andrea

bug#48021: comp.el cannot be loaded without native compilation

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:

> Glenn Morris <rgm@gnu.org> writes:
>
>> Andrea Corallo wrote:
>>
>>>> ./src/emacs -Q -l ./lisp/emacs-lisp/comp.el
>>>>
>>>>    memq: Symbol's value as variable is void: comp-ctxt
>>
>>> with a390a4965f comp-cstr-tests run clean for me also on vanilla build,
>>> please let me know if this is sufficient for the case you are testing.
>>
>> Thanks. comp-cstr-test-70 is still failing for me.
>
> Could you share the invocation you are using? I'm asking cause here on
> 449045b2a6 I see this passing.
>
>>
>> The issue about comp.el being unloadable in builds without native
>> compilation remains (and hence test-custom-deps still fails).
>
> I didn't know about the test-custom-deps, I'll have a look.

Hi Glenn,

with 40c71e574a comp-cstr.el and comp.el are loadable for me also on
vanilla builds, please have a look.

Thanks

  Andrea

bug#48021: comp.el cannot be loaded without native compilation

[Glenn Morris]

Andrea Corallo wrote:

>>> Thanks. comp-cstr-test-70 is still failing for me.
>>
>> Could you share the invocation you are using? I'm asking cause here on
>> 449045b2a6 I see this passing.

On CentOS 8.3 with gcc 8.3, I get:

Test comp-cstr-test-70 condition:
    (ert-test-failed
     ((should
       (equal
       (comp-cstr-test-ts ...)
       '...))
      :form
      (equal
       (not
       (member b a))
       (not
       (member a b)))

There is an identical failure on the very different system
https://hydra.nixos.org/build/142153876

> with 40c71e574a comp-cstr.el and comp.el are loadable for me also on
> vanilla builds, please have a look.

Works for me, thanks.

bug#48021: comp.el cannot be loaded without native compilation

[Glenn Morris]

>>>> Thanks. comp-cstr-test-70 is still failing for me.
>>>
>>> Could you share the invocation you are using? I'm asking cause here on
>>> 449045b2a6 I see this passing.
>
> On CentOS 8.3 with gcc 8.3, I get:
>
> Test comp-cstr-test-70 condition:
>     (ert-test-failed
>      ((should
>        (equal
>        (comp-cstr-test-ts ...)
>        '...))
>       :form
>       (equal
>        (not
>        (member b a))
>        (not
>        (member a b)))
>
> There is an identical failure on the very different system
> https://hydra.nixos.org/build/142153876

Same failure on Debian testing.

bug#48021: comp.el cannot be loaded without native compilation

[Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Glenn Morris <rgm@gnu.org> writes:

>>>>> Thanks. comp-cstr-test-70 is still failing for me.
>>>>
>>>> Could you share the invocation you are using? I'm asking cause here on
>>>> 449045b2a6 I see this passing.
>>
>> On CentOS 8.3 with gcc 8.3, I get:
>>
>> Test comp-cstr-test-70 condition:
>>     (ert-test-failed
>>      ((should
>>        (equal
>>        (comp-cstr-test-ts ...)
>>        '...))
>>       :form
>>       (equal
>>        (not
>>        (member b a))
>>        (not
>>        (member a b)))
>>
>> There is an identical failure on the very different system
>> https://hydra.nixos.org/build/142153876
>
> Same failure on Debian testing.

Hi Glenn,

39ebc2689b should fix this, please have a look.

Thanks

  Andrea

bug#48021: comp.el cannot be loaded without native compilation

[Glenn Morris]

Andrea Corallo wrote:

> 39ebc2689b should fix this, please have a look.

Works for me, thanks for the fix.