From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>, emacs-devel@gnu.org, vibhavp@gmail.com
Subject: Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available.
Date: Tue, 04 Oct 2022 18:44:38 +0000 [thread overview]
Message-ID: <xjfedvn8m3t.fsf@ma.sdf.org> (raw)
In-Reply-To: <83pmffiwko.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Sep 2022 14:10:15 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Po Lu <luangruo@yahoo.com>
>> Cc: Vibhav Pant <vibhavp@gmail.com>
>> Date: Wed, 28 Sep 2022 08:22:36 +0800
>>
>> BTW, I don't see any code that loads this function dynamically on MS
>> Windows. Isn't that needed?
>
> They were present in the patch that was posted.
>
> FWIW, I'd like to see some rationale for these changes. Perhaps
> libgccjit experts would see it immediately without any explanations,
> but I'm not such an expert. TIA.
I think having explicit casts expressed to the compiler (instead of
working it around with unions as we do now) could enable the compiler
for better optimizations or maybe even some compile time gain. Before
libgccjit did not allow for expressing it, so it's good that now we take
advantage of it when available.
Best Regards
Andrea
prev parent reply other threads:[~2022-10-04 18:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166430063807.1861.17209317756638644499@vcs2.savannah.gnu.org>
[not found] ` <20220927174358.8443FC00A6E@vcs2.savannah.gnu.org>
2022-09-28 0:22 ` feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available Po Lu
2022-09-28 11:10 ` Eli Zaretskii
2022-10-02 16:24 ` Vibhav Pant
2022-10-04 18:44 ` Andrea Corallo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfedvn8m3t.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
--cc=vibhavp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.