From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: master c622627: * Clean-up temporary eln test-suite directory when exiting (bug#48060) Date: Thu, 29 Apr 2021 14:41:47 +0000 Message-ID: References: <20210427213426.6174.29110@vcs0.savannah.gnu.org> <20210427213427.8318C20D0F@vcs0.savannah.gnu.org> <87pmyebq8y.fsf@gmx.de> <834kfqhakv.fsf@gnu.org> <83y2d2dxel.fsf@gnu.org> <83v985ekfl.fsf@gnu.org> <83h7jpe94q.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40571"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, michael.albinus@gmx.de To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 29 16:43:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lc7tO-000AQR-22 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 16:43:50 +0200 Original-Received: from localhost ([::1]:58146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lc7tN-0004Ff-28 for ged-emacs-devel@m.gmane-mx.org; Thu, 29 Apr 2021 10:43:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50288) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lc7ri-00036a-J6 for emacs-devel@gnu.org; Thu, 29 Apr 2021 10:42:06 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:55304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lc7rZ-0004bK-9m; Thu, 29 Apr 2021 10:42:01 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 13TEflCQ014214 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 29 Apr 2021 14:41:48 GMT In-Reply-To: <83h7jpe94q.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 29 Apr 2021 12:24:21 +0300") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268615 Archived-At: Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: Eli Zaretskii , michael.albinus@gmx.de >> Date: Thu, 29 Apr 2021 08:29:17 +0000 >> >> That said this could help in the file clean-up side of the problem, but >> IIUC the complain of this thread is the dependency Makefile -> >> stratup.el. > > With that preferred solution, startup.el will not need to be changed, > will it? > >> Than the real question is how should Emacs understand that is being used >> for a testsuite run so it can use "test/eln-cache/" without any >> dependency Makefile -> Emacs? > > I'm not sure what dependency you are talking about. What I had in > mind was to arrange in test/Makefile.in to use that directory for > *.eln files, via some Lisp variable or environment variable. This > way, Emacs will not need to understand it is being run as part of the > test suite. Answering both your questions: Emacs will have to understand that in this condition "test/eln-cache/" has to be pushed to `comp-eln-load-path'. To do this as you suggest we could set an env-var, but this is not much different from what we do now (and IIUC this is what Michael doesn't like much and was called a dependency). Also we'd still have to handle this push in startup.el, am I wrong? Maybe we could have the Emacs invocation in the Makefile changed to explicitly tweak `comp-eln-load-path' using -eval? Regards Andrea