From: Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 44209@debbugs.gnu.org
Cc: whatson@gmail.com, larsi@gnus.org
Subject: bug#44209: 28.0.50; [feature/native-comp] Compilation failure in progmodes/js.el
Date: Sun, 25 Oct 2020 23:06:56 +0000 [thread overview]
Message-ID: <xjfblgphpm7.fsf@sdf.org> (raw)
In-Reply-To: <xjfft62gewf.fsf@sdf.org> (Andrea Corallo via's message of "Sun, 25 Oct 2020 21:43:44 +0000")
Andrea Corallo via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs@gnu.org> writes:
> Okay I think I see what is going on:
>
> We fail to inline `cc-bytecomp-is-compiling' inside cc-defs.el because
> `cc-bytecomp-is-compiling' is native compiled even if it should not.
> We do not native compile defsubsts so they can be disassebled by the
> bytecompiler to have the inlining performed effectively.
>
> Prove of this is that adding (declare (speed -1)) to
> `cc-bytecomp-is-compiling' to prevent native compialtion fix the
> issue.
>
> Now why defsubst is failing to do the same automatically is another
> question I have to look into. I suspect this issue is also the cause
> of some of the warnings we see during the native build.
All right 5edc7aa019 fix the issue for me. I've also added a testcase
so hopefully we have it under control for the future.
Andrea
next prev parent reply other threads:[~2020-10-25 23:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 11:06 bug#44209: 28.0.50; [feature/native-comp] Compilation failure in progmodes/js.el Andrew Whatson
2020-10-25 13:16 ` Lars Ingebrigtsen
2020-10-25 13:52 ` Andrew Whatson
2020-10-25 14:25 ` Lars Ingebrigtsen
2020-10-25 14:42 ` Andrew Whatson
2020-10-25 14:55 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 15:11 ` Andrew Whatson
2020-10-25 15:21 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 15:02 ` Lars Ingebrigtsen
2020-10-25 15:30 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 15:57 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 16:13 ` Lars Ingebrigtsen
2020-10-25 21:43 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-10-25 23:06 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2020-10-25 23:44 ` Lars Ingebrigtsen
2020-10-26 1:08 ` Andrew Whatson
2020-10-26 7:37 ` Andrea Corallo via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfblgphpm7.fsf@sdf.org \
--to=bug-gnu-emacs@gnu.org \
--cc=44209@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=larsi@gnus.org \
--cc=whatson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.