From: Andrea Corallo via "Emacs development discussions." <emacs-devel@gnu.org>
To: Arthur Miller <arthur.miller@live.com>
Cc: emacs-devel@gnu.org
Subject: Re: Native compiler - passing command line options to C compiler
Date: Mon, 30 Aug 2021 09:36:09 +0000 [thread overview]
Message-ID: <xjfa6kz46ly.fsf@ma.sdf.org> (raw)
In-Reply-To: <AM9PR09MB49778CFA83AA6697D09ED01B96CA9@AM9PR09MB4977.eurprd09.prod.outlook.com> (Arthur Miller's message of "Sun, 29 Aug 2021 23:47:56 +0200")
Arthur Miller <arthur.miller@live.com> writes:
> Hi again,
>
> after the few mails the other day, I wasn't really sure if Andrea is going to
> implement it and when.
Sure I was going to implent it as I said so, but thanks for taking the
task :)
> I thought it was rather a tedious manual labour and maybe
> not so important, so I took me a liberty to implement this myself in my own, so
> called, personal copy of Eamcs sources.
>
> I am not sure if I have done it correctly though, I appreciate if Andrea have
> time to take a look;
I just have a small suggestion.
> Mark set
>
> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
> index 80a1da5ad8..58d361cf46 100644
> --- a/lisp/emacs-lisp/comp.el
> +++ b/lisp/emacs-lisp/comp.el
> @@ -166,6 +166,16 @@ native-comp-async-query-on-exit
> :type 'boolean
> :version "28.1")
>
> +(defcustom native-comp-compiler-options nil
> + "Options passed verbatim to the native compiler's c driver.
I'd just say "passed to the compiler" or "passed to GCC" as there's no C
involed.
> +#endif
> + if (CONSP (options))
> + xsignal1 (Qnative_compiler_error,
> + build_string ("Customizing native compiler options"
> + " via `comp-native-compiler-options' is"
> + " only available on libgccjit version 9"
> + " and above."));
> +
> + /* Captured `comp-native-driver-options' because file-local. */
^^^
native-comp-compiler-options ?
Other that that the patch LGTM. Could you provide it with its
Changelog?
TIA
Andrea
next parent reply other threads:[~2021-08-30 9:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AM9PR09MB49778CFA83AA6697D09ED01B96CA9@AM9PR09MB4977.eurprd09.prod.outlook.com>
2021-08-30 9:36 ` Andrea Corallo via Emacs development discussions. [this message]
2021-08-30 13:56 ` Native compiler - passing command line options to C compiler Arthur Miller
2021-08-30 14:05 ` Andrea Corallo via Emacs development discussions.
2021-08-30 11:42 ` Eli Zaretskii
2021-08-30 12:59 ` Andrea Corallo via Emacs development discussions.
2021-08-30 13:28 ` Eli Zaretskii
2021-08-30 14:28 ` Andrea Corallo via Emacs development discussions.
2021-08-30 15:00 ` Arthur Miller
2021-08-30 15:38 ` Andrea Corallo via Emacs development discussions.
2021-08-31 5:36 ` Arthur Miller
2021-08-31 8:06 ` Andrea Corallo via Emacs development discussions.
2021-08-31 13:01 ` Eli Zaretskii
2021-08-31 22:53 ` Arthur Miller
2021-09-01 11:45 ` Eli Zaretskii
2021-09-01 14:23 ` Arthur Miller
2021-09-01 16:45 ` Eli Zaretskii
2021-09-01 21:06 ` Arthur Miller
2021-08-30 16:01 ` Eli Zaretskii
2021-08-30 15:50 ` Eli Zaretskii
2021-08-30 14:01 ` Arthur Miller
2021-08-30 14:03 ` Eli Zaretskii
2021-09-01 14:58 ` Alex Bennée
2021-09-01 15:10 ` Perry E. Metzger
2021-09-01 16:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjfa6kz46ly.fsf@ma.sdf.org \
--to=emacs-devel@gnu.org \
--cc=akrl@sdf.org \
--cc=arthur.miller@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.