From: Andrea Corallo <akrl@sdf.org>
To: "Nicolas Bértolo" <nicolasbertolo@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: [PATCH] [WIP] Port feature/native-comp to Windows.
Date: Wed, 13 May 2020 14:31:51 +0000 [thread overview]
Message-ID: <xjf8shvucrs.fsf@sdf.org> (raw)
In-Reply-To: <CAFnS-OnYzkbqo2dN9mC6Oeu=NS6xCjJwU8F2NhvjDC=KzZutVg@mail.gmail.com> ("Nicolas Bértolo"'s message of "Wed, 13 May 2020 11:09:42 -0300")
Nicolas Bértolo <nicolasbertolo@gmail.com> writes:
>> I think Qjson is a refuse from kill and yank.
>
> Heh, it turns out that fixing that uncovered a bug. We need to clear
> Vlibrary_cache when loading a dump (or prevent it from being dumped) because
> otherwise it will have a `gccjit` entry from when temacs loaded libgccjit and
> then w32_delayed_load() will think that libgccjit is already loaded in the
> process.
>
> New version attached.
Hi Nicolas, thanks
+ static bool tried_to_initialize_once;
+ static bool gccjit_initialized;
+
+ if (!tried_to_initialize_once)
+ {
+ tried_to_initialize_once = true;
+ Lisp_Object status;
+ gccjit_initialized = init_gccjit_functions ();
+ status = gccjit_initialized ? Qt : Qnil;
+ Vlibrary_cache = Fcons (Fcons (Qgccjit, status), Vlibrary_cache);
+ }
+
+ if (mandatory && !gccjit_initialized)
+ xsignal1(Qnative_compiler_error, build_string("libgccjit not found"));
+
+ return gccjit_initialized;
I see you have introduced tried_to_initialize_once. I'm not sure this
is convenient because a user could, after a failed attempt, fix his
environment to load libgccjit and do it without restarting Emacs.
Is there some specific reason for this choice?
> PS: Shall I open a bug where we can track this?
If affect all Emacs I think is the right thing to do.
> Nicolas
Thanks!
Andrea
--
akrl@sdf.org
next prev parent reply other threads:[~2020-05-13 14:31 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 19:55 [PATCH] [WIP] Port feature/native-comp to Windows Nicolas Bertolo
2020-05-08 22:00 ` Andrea Corallo
2020-05-08 22:11 ` Nicolas Bértolo
2020-05-08 22:22 ` Andrea Corallo
2020-05-08 22:23 ` Nicolas Bértolo
2020-05-08 22:27 ` Andrea Corallo
2020-05-08 23:18 ` Stefan Monnier
2020-05-09 6:07 ` Eli Zaretskii
2020-05-09 15:28 ` Nicolas Bértolo
2020-05-09 15:48 ` Eli Zaretskii
2020-05-09 17:09 ` Andrea Corallo
2020-05-10 16:36 ` Nicolas Bértolo
2020-05-10 17:08 ` Eli Zaretskii
2020-05-10 17:50 ` Nicolas Bértolo
2020-05-10 18:22 ` Eli Zaretskii
2020-05-10 19:02 ` Nicolas Bértolo
2020-05-10 19:16 ` Eli Zaretskii
2020-05-10 19:41 ` Nicolas Bértolo
2020-05-10 19:50 ` Andrea Corallo
2020-05-10 19:55 ` Nicolas Bértolo
2020-05-10 20:01 ` Andrea Corallo
2020-05-11 14:19 ` Eli Zaretskii
2020-05-11 14:17 ` Eli Zaretskii
2020-05-11 15:20 ` Nicolas Bértolo
2020-05-11 16:19 ` Eli Zaretskii
2020-05-11 16:43 ` Andrea Corallo
2020-05-11 16:44 ` Nicolas Bértolo
2020-05-11 17:05 ` Eli Zaretskii
2020-05-11 18:19 ` Fabrice Popineau
2020-05-11 18:37 ` Andrea Corallo
2020-05-11 18:48 ` Eli Zaretskii
2020-05-11 19:27 ` Stefan Monnier
2020-05-11 19:42 ` Fabrice Popineau
2020-05-12 2:46 ` Nicolas Bértolo
2020-05-12 16:56 ` Eli Zaretskii
2020-05-12 17:25 ` Nicolas Bértolo
2020-05-12 18:21 ` Andrea Corallo
2020-05-12 20:33 ` Andrea Corallo
2020-05-13 14:09 ` Nicolas Bértolo
2020-05-13 14:31 ` Andrea Corallo [this message]
2020-05-13 15:00 ` Nicolas Bértolo
2020-05-13 15:17 ` Andrea Corallo
2020-05-13 15:48 ` Eli Zaretskii
2020-05-13 3:59 ` Richard Stallman
2020-05-13 14:02 ` Nicolas Bértolo
2020-05-13 15:23 ` Eli Zaretskii
2020-05-13 14:52 ` Eli Zaretskii
2020-05-10 19:47 ` Andrea Corallo
2020-05-10 19:39 ` Andrea Corallo
2020-05-10 17:13 ` Andrea Corallo
2020-05-10 17:15 ` Eli Zaretskii
2020-05-10 18:14 ` Andrea Corallo
2020-05-10 18:30 ` Eli Zaretskii
2020-05-10 18:54 ` Andrea Corallo
2020-05-10 19:02 ` Eli Zaretskii
2020-05-10 19:07 ` Nicolas Bértolo
2020-05-10 19:14 ` Andrea Corallo
2020-05-10 19:24 ` Andrea Corallo
2020-05-10 19:30 ` Eli Zaretskii
2020-05-10 18:05 ` Nicolas Bértolo
2020-05-10 18:23 ` Andrea Corallo
2020-05-10 17:20 ` Andrea Corallo
2020-05-09 13:42 ` Andrea Corallo
2020-05-09 15:40 ` Nicolas Bértolo
2020-05-09 15:55 ` Eli Zaretskii
2020-05-09 16:07 ` Nicolas Bértolo
2020-05-09 16:15 ` Eli Zaretskii
2020-05-09 16:27 ` Andrea Corallo
2020-05-09 16:33 ` Eli Zaretskii
2020-05-09 16:46 ` Andrea Corallo
2020-05-09 16:52 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjf8shvucrs.fsf@sdf.org \
--to=akrl@sdf.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=nicolasbertolo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.