From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [feature/native-comp] breakage on build Date: Wed, 10 Feb 2021 08:44:57 +0000 Message-ID: References: <87lfca7lsb.fsf@russet.org.uk> <87wnvn5yoz.fsf@russet.org.uk> <87eehuomn2.fsf@russet.org.uk> <83lfc2px16.fsf@gnu.org> <87czxe45f8.fsf@russet.org.uk> <8335yap6p8.fsf@gnu.org> <87wnvm2nhb.fsf@russet.org.uk> <83wnvlod0k.fsf@gnu.org> <87wnvlmjxo.fsf@russet.org.uk> <83ft29nwc0.fsf@gnu.org> <87y2fzr8ve.fsf@russet.org.uk> <87ft26pxra.fsf@russet.org.uk> <877dnipqfh.fsf@russet.org.uk> <877dng988w.fsf@russet.org.uk> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18852"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier , Andrea Corallo via "Emacs development discussions." , Eli Zaretskii To: Phillip Lord Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 10 09:46:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9l8r-0004o9-4r for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 09:46:33 +0100 Original-Received: from localhost ([::1]:38766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9l8q-00063Y-86 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 03:46:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9l7O-0005FX-BY for emacs-devel@gnu.org; Wed, 10 Feb 2021 03:45:02 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:59977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9l7L-0007cm-OG; Wed, 10 Feb 2021 03:45:02 -0500 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 11A8ivvV027665 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 10 Feb 2021 08:44:57 GMT In-Reply-To: <877dng988w.fsf@russet.org.uk> (Phillip Lord's message of "Tue, 09 Feb 2021 22:38:55 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264262 Archived-At: Phillip Lord writes: > Andrea Corallo writes: > >> Stefan Monnier writes: >> >>>> - With native code you can redefine all of these except for the (very >>>> few) primitives we open-code directly in the generated code. This is >>>> a smaller set than the previous one but still not perfect. >>> >>> But if we can't build trampolines, currently, the situation is much >>> worse: many calls to native-compiled Lisp functions from native-compile= d Lisp >>> functions can't be advised any more. >> >> Correct, but if we can build eln files during the initial compilation we >> can also build trampolines AOT. This is just a matter of running: >> >> (mapatoms (=CE=BB (s)=20=20=20=20 >> (when (subr-primitive-p (symbol-function s)) >> (comp-trampoline-compile s)))) >> >> Probably we should wire this in the build system so it's accessible as >> make target? > > > Why not wire it into the AOT compilation always? Obviously, if it > doubles the AOT compilation, that might not be such a great idea, but > otherwise? > > Phil That's a great question. Compiling a trampoline is about 0.2s each (mostly GCC gas ld startup time). Say we have ~1400 primitives this should translate into ~4.5 min of build time for something that in the average case is largely unused. The trouble is that the simple code snippet I posted is not parallel and there's no trivial way to make make aware of all these targets to have it handling the parallelism. Andrea