From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows - Determine the emacs root dir... Date: Fri, 29 May 2020 12:12:49 +0000 Message-ID: References: <83k10wshvg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="83240"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 41242@debbugs.gnu.org To: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 29 14:13:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jedsv-000LWd-11 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 May 2020 14:13:13 +0200 Original-Received: from localhost ([::1]:56470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jedst-0005VA-J2 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 29 May 2020 08:13:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54610) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jedsk-0005Us-NO for bug-gnu-emacs@gnu.org; Fri, 29 May 2020 08:13:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42502) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jedsk-0003CO-Dv for bug-gnu-emacs@gnu.org; Fri, 29 May 2020 08:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jedsk-00017U-8z for bug-gnu-emacs@gnu.org; Fri, 29 May 2020 08:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 May 2020 12:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.15907543744288 (code B ref 41242); Fri, 29 May 2020 12:13:02 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 29 May 2020 12:12:54 +0000 Original-Received: from localhost ([127.0.0.1]:54048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jedsc-000176-51 for submit@debbugs.gnu.org; Fri, 29 May 2020 08:12:54 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:52949) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jedsa-00016t-DF for 41242@debbugs.gnu.org; Fri, 29 May 2020 08:12:52 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04TCCnWo005567 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 29 May 2020 12:12:49 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04TCCnxY009324; Fri, 29 May 2020 12:12:49 GMT In-Reply-To: ("Nicolas =?UTF-8?Q?B=C3=A9rtolo?="'s message of "Thu, 28 May 2020 21:39:55 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181182 Archived-At: Nicolas B=C3=A9rtolo writes: > Hi, > > I have taken your comments into consideration and updated the patch. Hi thanks, looks more clear to me. question: what if instead of using Ffile_exists we just use fopen to check if the file exists in dump_do_dump_relocation? I think the origin of "the trouble" is just there while checking if a file exists, the path in discussion should be already absolute by construction so I suspect we do not need Fexpand_file to come into play. Haven't tried, but if it works looks to me cleaner then entering in logic where not everything is initialized. It's true that now you have verified that with your patch the execution path does not involve variables to be initialized, but the logic could change in the future. What do you think? Thanks Andrea --=20 akrl@sdf.org