From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Finalizing 'inhibit-automatic-native-compilation' Date: Mon, 13 Feb 2023 19:34:43 +0000 Message-ID: References: <837cx8cey0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32422"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org, Lars Ingebrigtsen , Rob Browning To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 13 20:36:02 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRecM-0008F8-Bo for ged-emacs-devel@m.gmane-mx.org; Mon, 13 Feb 2023 20:36:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRebu-0000Q7-0y; Mon, 13 Feb 2023 14:35:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRebs-0000Pp-7O for emacs-devel@gnu.org; Mon, 13 Feb 2023 14:35:32 -0500 Original-Received: from mab.sdf.org ([205.166.94.33] helo=ma.sdf.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRebA-0000M2-Fg; Mon, 13 Feb 2023 14:35:31 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1pReb5-0003I8-Uh; Mon, 13 Feb 2023 19:34:43 +0000 In-Reply-To: (Stefan Monnier's message of "Mon, 13 Feb 2023 14:17:16 -0500") Received-SPF: pass client-ip=205.166.94.33; envelope-from=akrl@sdf.org; helo=ma.sdf.org X-Spam_score_int: 31 X-Spam_score: 3.1 X-Spam_bar: +++ X-Spam_report: (3.1 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SBL_CSS=3.335, RCVD_IN_VALIDITY_RPBL=1.31, RCVD_IN_XBL=0.375, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:303228 Archived-At: Stefan Monnier writes: >> at feature/inhibit-native-comp-cleanup I've pushed the branch I'm >> testing that: >> >> . removes the EMACS_INHIBIT_AUTOMATIC_NATIVE_COMPILATION environment >> variable >> . removes `inhibit-automatic-native-compilation' variable and uses >> `native-comp-deferred-compilation', with or without >> `comp-enable-subr-trampolines' (as needed), instead >> . adds a third possible value to `comp-enable-subr-trampolines', a >> string that specifies a directory in which to deposit the JIT >> compiled trampolines >> . updates the doc string of `native-comp-never-optimize-functions' to >> mention its effect on trampolines >> . updates some do doc here and there accordingly > > The one thing which I think would help avoid surprises is: > > when `comp-enable-subr-trampolines` is non-nil (and not a string) and > ~/.emacs.d/eln-cache is not writable (e.g. because $HOME doesn't exist) > we should produce the trampolines somewhere in > `temporary-file-directory` (maybe by setting > `comp-enable-subr-trampolines` to an appropriate string) > > > Stefan Hi Stefan, I'm positive about the concept of staying on the safe side on this, I'm just not a big fan of leaving `comp-enable-subr-trampolines' value mutated. Dunno maybe we should just trying `temporary-file-directory' as last resource in our search for a suitable place for a trampoline? BR Andrea