From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: On elisp running native - Update 12 Date: Sat, 26 Sep 2020 14:56:54 +0000 Message-ID: References: <83o8uegykm.fsf@gnu.org> <74dd94a9-28cb-a5fd-dbc7-ab21009834ad@cs.ucla.edu> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15408"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Andrea Corallo via "Emacs development discussions." , Eli Zaretskii , Stefan Monnier , rms@gnu.org To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 26 16:57:42 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMBdt-0003uP-Pi for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Sep 2020 16:57:41 +0200 Original-Received: from localhost ([::1]:54064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMBds-0002SN-SJ for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Sep 2020 10:57:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMBdD-0001zb-6R for emacs-devel@gnu.org; Sat, 26 Sep 2020 10:56:59 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:52800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMBdB-00039O-4k; Sat, 26 Sep 2020 10:56:58 -0400 Original-Received: from mab (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTP id 08QEusBj000397; Sat, 26 Sep 2020 14:56:54 GMT In-Reply-To: (T. V. Raman's message of "Sat, 26 Sep 2020 07:29:03 -0700") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/26 10:56:55 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256470 Archived-At: "T.V Raman" writes: > Hi Andrea, Hi! > This looks awesome. > > A couple of questions: > > Now that you handle the optimization declarations from cl, could you > also handle cl-declaim of the same --- typically used in CL at > top-level / start-of file? > > > (cl-declaim (optimize (safety 0) (speed 3))) ATM `cl-declaim' (as `cl-proclaim') are not effective regarding the speed parameter of the native compiler. To a quick look to the HyperSpec I guess `cl-declaim' should just set `comp-speed' other than what is already doing, shall do it. > 2. In your example for advising primitives, you show the generate > dfunction as > (defun --subr-trampoline-delete-file (filename &optional trash) > (funcall filename trash)) > > Should the above check if delete-file was called interactively, and > if yes, in turn call funcall-interactively? Interesting, I think should be fine like it is now as Lisp code is calling explicitly `funcall-interactively' anyway. Andrea