From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.bugs Subject: bug#41242: Port feature/native-comp to Windows - Determine the emacs root dir... Date: Sat, 30 May 2020 14:51:10 +0000 Message-ID: References: <83k10wshvg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="104498"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 41242@debbugs.gnu.org To: Nicolas =?UTF-8?Q?B=C3=A9rtolo?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 30 16:52:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jf2qI-000R5q-RX for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 16:52:10 +0200 Original-Received: from localhost ([::1]:53924 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jf2qH-00026s-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 May 2020 10:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35674) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jf2qA-00026Z-3u for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 10:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47343) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jf2q9-0004WF-R6 for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 10:52:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jf2q9-0003r8-Pm for bug-gnu-emacs@gnu.org; Sat, 30 May 2020 10:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andrea Corallo Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 May 2020 14:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41242 X-GNU-PR-Package: emacs Original-Received: via spool by 41242-submit@debbugs.gnu.org id=B41242.159085027414766 (code B ref 41242); Sat, 30 May 2020 14:52:01 +0000 Original-Received: (at 41242) by debbugs.gnu.org; 30 May 2020 14:51:14 +0000 Original-Received: from localhost ([127.0.0.1]:58889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf2pN-0003q5-SS for submit@debbugs.gnu.org; Sat, 30 May 2020 10:51:14 -0400 Original-Received: from mx.sdf.org ([205.166.94.20]:52687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jf2pM-0003px-83 for 41242@debbugs.gnu.org; Sat, 30 May 2020 10:51:13 -0400 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 04UEpAuc004172 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Sat, 30 May 2020 14:51:10 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id 04UEpAx5022144; Sat, 30 May 2020 14:51:10 GMT In-Reply-To: ("Nicolas =?UTF-8?Q?B=C3=A9rtolo?="'s message of "Sat, 30 May 2020 10:23:55 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181231 Archived-At: Nicolas B=C3=A9rtolo writes: > I have found a few bugs in Windows. > Patches attached (they are in my repo too). > > - It is still a good idea to avoid the call to getenv("emacs_dir"), if on= ly for > performance reasons. I guess this should then go into master right? Probably also others likes to review it, in case should not be discussed in this thread. > - We can't use "gensym" for register_native_comp_unit() because the dynam= ic > library may not have been loaded yet when loading a dump file. The code LGTM, I just think instead of make_fixum you could use make_int to have some more room (not sure how much is realistic this scenario but comes for free). > - Commit `f5dceed09a8234548d5b3acb76d443569533cab9` "* lisp/loadup.el: Us= e new > 'native-comp-available-p'." causes load_gccjit_if_necessary() to be cal= led in > temacs. This didn't work because because term/w32-win.el had not been l= oaded > yet. In particular, we need `dynamic-library-alist` to be defined to kn= ow the > name of the libgccjit DLL. I have defined this in syms_of_emacs(). This > definition should be active only while dumping. I'll look into. > - This last bug is kinda confusing. I'm not sure about my diagnosis. The = list > `delayed_comp_unit_disposal_list` has nodes allocated with xmalloc(). I= t seems > that these blocks allocated with xmalloc() get GC'd or they get corrupt= ed > somehow and thus they don't survive until Emacs is about to close, whic= h is > when we need the list. I solved it by allocating the data and nodes with > HeapAlloc(). I think this issue deserves to be precisely understood. Thanks Andrea --=20 akrl@sdf.org