From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.bugs Subject: bug#39145: 28.0.50; dired: Show broken/circular links in different font Date: Wed, 15 Jan 2020 17:28:47 -0500 Message-ID: References: <87d0bk1lat.fsf@calancha-pc.dy.bbexcite.jp> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="54347"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: 39145@debbugs.gnu.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 23:29:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irrA1-000E6e-SA for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 23:29:13 +0100 Original-Received: from localhost ([::1]:33356 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irrA0-00066e-RP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 17:29:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37107) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irr9r-00064z-ON for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:29:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irr9q-0003Pq-HN for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:29:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58709) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irr9q-0003PU-EN for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irr9q-0006Ac-CA for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 17:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39145 X-GNU-PR-Package: emacs Original-Received: via spool by 39145-submit@debbugs.gnu.org id=B39145.157912733823693 (code B ref 39145); Wed, 15 Jan 2020 22:29:02 +0000 Original-Received: (at 39145) by debbugs.gnu.org; 15 Jan 2020 22:28:58 +0000 Original-Received: from localhost ([127.0.0.1]:36447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irr9m-0006A5-KR for submit@debbugs.gnu.org; Wed, 15 Jan 2020 17:28:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irr9k-00069p-Cc for 39145@debbugs.gnu.org; Wed, 15 Jan 2020 17:28:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44857) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1irr9f-0003HJ-72; Wed, 15 Jan 2020 17:28:51 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1irr9b-0003NX-K9; Wed, 15 Jan 2020 17:28:48 -0500 X-Spook: AMEMB Closure Tucson Venezuela White House Panama SWAT X-Ran: X`r;r1+u=&_]Dm"ZN|`=Fg%EFEW-Ahd'PNN2;'zn{9%.iBi]*<s5s~XfU')5(Lsi><>N X-Hue: brightblue X-Attribution: GM In-Reply-To: <87d0bk1lat.fsf@calancha-pc.dy.bbexcite.jp> (Tino Calancha's message of "Wed, 15 Jan 2020 22:06:50 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174677 Archived-At: Tino Calancha wrote: > +(defface dired-broken-symlink > + '((((class color)) > + :foreground "yellow1" :background "red1" :weight bold) > + (t :weight bold :slant italic :underline t)) > + "Face used for broken symbolic links." > + :group 'dired-faces > + :version "28.1") > + > +(defvar dired-broken-symlink-face 'dired-broken-symlink > + "Face name used for broken symbolic links.") Why have a variable at all, why not just customize the face? (If it's just for consistency with existing dired stuff, consider breaking that consistency.)