From: Zhengyi Fu <i@fuzy.me>
To: 73801@debbugs.gnu.org
Subject: bug#73801: 31.0.50; project-try-vc sometimes set wrong cache project-vc-extra-root-markers
Date: Mon, 14 Oct 2024 14:29:48 +0800 [thread overview]
Message-ID: <xifv7wldyrnqn7.fsf@hp.com> (raw)
Consider the following project:
test-project/
├── .git/
└── subproject/
├── marker
└── subdir/
If `project-vc-extra-root-markers' is set to `("marker")' and
`project-try-vc' is invoked with `test-project/subproject/subdir', it will set the `project-vc'
VC property of the `test-project/subproject' directory to
`(".../test-project" project-vc nil)', so if later `project-try-vc' is
invoked with that directory, it will return a wrong result.
This is because project-vc tries to detect the VC backend by invoking
`project-try-vc' on the subproject while let binding
`project-vc-extra-root-markers' to nil and the result is cached.
The following patch can fix the problem:
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -595,7 +595,7 @@ project-try-vc
(let* ((project-vc-extra-root-markers nil)
;; Avoid submodules scan.
(enable-dir-local-variables nil)
- (parent (project-try-vc root)))
+ (parent (project-try-vc dir)))
(and parent (setq backend (nth 1 parent)))))
(setq project (list 'vc backend root))
;; FIXME: Cache for a shorter time.
next reply other threads:[~2024-10-14 6:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-14 6:29 Zhengyi Fu [this message]
2024-10-27 10:31 ` bug#73801: 31.0.50; project-try-vc sometimes set wrong cache project-vc-extra-root-markers Eli Zaretskii
2024-10-28 4:06 ` Dmitry Gutov
2024-10-29 2:44 ` Dmitry Gutov
2024-10-29 13:33 ` Eli Zaretskii
2024-10-29 20:31 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xifv7wldyrnqn7.fsf@hp.com \
--to=i@fuzy.me \
--cc=73801@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.