From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r115918: package.el: various fixes. Date: Wed, 08 Jan 2014 12:05:56 -0500 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1389200761 20278 80.91.229.3 (8 Jan 2014 17:06:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 8 Jan 2014 17:06:01 +0000 (UTC) Cc: Bastien Guerry , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 08 18:06:07 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W0wZy-0000S7-7G for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 18:06:06 +0100 Original-Received: from localhost ([::1]:47988 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0wZx-0007ud-Ow for ged-emacs-devel@m.gmane.org; Wed, 08 Jan 2014 12:06:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37697) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0wZr-0007uU-BI for emacs-devel@gnu.org; Wed, 08 Jan 2014 12:06:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0wZq-0002AC-Bq for emacs-devel@gnu.org; Wed, 08 Jan 2014 12:05:59 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41150) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0wZq-0002A7-8R for emacs-devel@gnu.org; Wed, 08 Jan 2014 12:05:58 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W0wZo-000714-Ao; Wed, 08 Jan 2014 12:05:56 -0500 X-Spook: infowar ARPA mailbomb RSA Majic colonel bullion AFSPC X-Ran: jsx/?3m>9z-05OMdak9e)FX)]xVv?3o%Q/lBmlL8xt9=3DHU;cX|ml_E5*'&u=r8W6"W|* X-Hue: white X-Attribution: GM In-Reply-To: (Stefan Monnier's message of "Wed, 08 Jan 2014 09:16:39 -0500") User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167751 Archived-At: >> + (when (assq package package-alist) >> (or >> (let ((pkg-descs (cdr (assq package package-alist)))) This is redundant (accesses same thing twice). >> (and pkg-descs >> (version-list-<= min-version >> (package-desc-version (car pkg-descs))))) >> ;; Also check built-in packages. >> - (package-built-in-p package min-version))) >> + (package-built-in-p package min-version)))) It also seems to make the "Also check built-in packages." branch unreachable.