From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: display bug for empty lines in recent git snapshot Date: Wed, 17 Nov 2010 11:43:23 +0100 Message-ID: References: <87hbfgfg9v.fsf@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289990643 23229 80.91.229.12 (17 Nov 2010 10:44:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 17 Nov 2010 10:44:03 +0000 (UTC) Cc: Tassilo Horn , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 17 11:43:57 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PIfUZ-0006uw-Qg for ged-emacs-devel@m.gmane.org; Wed, 17 Nov 2010 11:43:55 +0100 Original-Received: from localhost ([127.0.0.1]:42108 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIfUZ-0000Us-5f for ged-emacs-devel@m.gmane.org; Wed, 17 Nov 2010 05:43:55 -0500 Original-Received: from [140.186.70.92] (port=40337 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIfUR-0000UR-Gi for emacs-devel@gnu.org; Wed, 17 Nov 2010 05:43:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIfUQ-0002IT-Bt for emacs-devel@gnu.org; Wed, 17 Nov 2010 05:43:47 -0500 Original-Received: from igloo.linux.gr ([62.1.205.36]:49145) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIfUN-0002HI-QM; Wed, 17 Nov 2010 05:43:44 -0500 X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-2.9, required 5, autolearn=not spam, ALL_TRUSTED -1.00, BAYES_00 -1.90) X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-ID: oAHAhNTG008786 Original-Received: from gkeramidas-glaptop.linux.gr ([74.125.57.36]) (authenticated bits=0) by igloo.linux.gr (8.14.3/8.14.3/Debian-9.4) with ESMTP id oAHAhNTG008786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 17 Nov 2010 12:43:30 +0200 In-Reply-To: <87hbfgfg9v.fsf@member.fsf.org> (Tassilo Horn's message of "Wed, 17 Nov 2010 10:31:08 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132775 Archived-At: On Wed, 17 Nov 2010 10:31:08 +0100, Tassilo Horn wrote: > Hi Giorgos, > > I've already filed this as bug#7417. The change that introduced this bug in my local mirror of the git trunk is one committed by Eli on Nov 13: : changeset: 111519:3355ca38548d : user: Eli Zaretskii : date: Sat Nov 13 15:29:31 2010 +0200 : files: doc/emacs/ChangeLog doc/emacs/display.texi doc/emacs/mule.texi : doc/emacs/rmail.texi doc/lispref/ChangeLog : doc/lispref/display.texi etc/ChangeLog etc/NEWS lisp/ChangeLog : lisp/international/characters.el src/.gdbinit src/ChangeLog : src/dispextern.h src/term.c src/w32term.c src/xdisp.c src/xterm.c : description: : Fix and document display of glyphless characters. : : src/xdisp.c (set_cursor_from_row): Fix cursor positioning on : zero-width characters. : (syms_of_xdisp) : Doc fix. : src/.gdbinit (pgx): Adapt to latest changes in `struct glyph'. : src/w32term.c (x_draw_glyphless_glyph_string_foreground): Draw the : box before drawing the glyphs inside it. : src/dispextern.h (enum glyphless_display_method): Rename : GLYPHLESS_DISPLAY_HEXA_CODE to GLYPHLESS_DISPLAY_HEX_CODE. All : users changed. : src/term.c (append_glyphless_glyph, produce_glyphless_glyph): Fix : comments. : (produce_glyphless_glyph): Enclose "U+nnnn" and "empty box" : whitespace in "[]", to simulate a box. Don't use uninitialized : variable `width'. : lisp/international/characters.el (glyphless-char-display-control): : Renamed from glyphless-char-control; all users changed. Doc fix. : Signal an error if display method is not one of the recognized : symbols. : doc/emacs/rmail.texi (Rmail Coding): Characters with no fonts are not : necessarily displayed as empty boxes. : doc/emacs/mule.texi (Language Environments, Fontsets): Characters with no : fonts are not necessarily displayed as empty boxes. : doc/emacs/display.texi (Text Display): Document display of glyphless : characters. : doc/lispref/display.texi (Usual Display): Characters with no fonts are not : necessarily displayed as empty boxes. : etc/NEWS: Document display of glyphless characters. I think there's some exception we have to add here for newline characters, because they are treated as GLYPHLESS_DISPLAY_THIN_SPACE or as GLYPHLESS_DISPLAY_EMPTY_BOX with a width of 1 space, but I am not sure what the best way to do this would be. Maybe Eli has a good idea of how this can be fixed?