From: Leo <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 5937@debbugs.gnu.org
Subject: bug#5937: 23.1.95; why saving empty abbrev tables
Date: Thu, 15 Apr 2010 11:26:55 +0100 [thread overview]
Message-ID: <xbaiwrw9j9jk.fsf@cam.ac.uk> (raw)
In-Reply-To: <jwvtyrgsf21.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 12 Apr 2010 14:32:07 -0400")
On 2010-04-12 19:32 +0100, Stefan Monnier wrote:
>> Why empty abbrev tables are saved to file?
>
> Don't know.
>
>> It seems to make it more difficult for editing (edit-abbrevs) because
>> the buffer is full of empty abbrev. I wonder if saving only non-empty
>> tables is better and user friendlier.
>
> It does sound like a good idea. Any objection?
I have been using this in my init file and I like it. It makes it easier
to see what's actually defined.
(defun abbrev-table-empty-p (table)
"Return nil if there are no abbrev symbols in abbrev table object
TABLE."
(unless (abbrev-table-p table)
(error "Non abbrev table object"))
(not (catch 'some
(mapatoms (lambda (sym)
(when (abbrev-symbol (symbol-name sym) table)
(throw 'some t)))
table))))
(defadvice prepare-abbrev-list-buffer (around nonempty-abbrev-tables
activate)
"Ignore empty abbrev tables."
(let ((abbrev-table-name-list
(loop for table in abbrev-table-name-list
unless (abbrev-table-empty-p (symbol-value table))
collect table)))
ad-do-it))
(defadvice write-abbrev-file (around nonempty-abbrev-tables activate)
"Ignore empty abbrev tables when writing to FILE."
(let ((abbrev-table-name-list
(loop for table in abbrev-table-name-list
unless (abbrev-table-empty-p (symbol-value table))
collect table)))
ad-do-it))
[...]
> Obviously, defadvice wouldn't be the right approach for us.
> And rather than (abbrev-symbol (symbol-name sym) table), we can use
> (symbol-value sym).
> We should also eliminate abbrev tables that only contain "system
> abbrevs".
Regarding the :system property, I have experienced some oddity but I
by-passed that instead of looking into it for lack of time.
Here's what happened.
When I use define-abbrev to define some system abbrevs and then M-x
edit-abbrevs and move to the table where those abbrevs are defined then
paste some non-system abbrevs from, for example, another abbrev file.
Those pasted abbrevs are treated as system abbrevs and not saved.
Sometimes when the table already have non-system abbrevs, they are
turned into system ones and get lost.
I had a backup of the abbrev file so that didn't cause me any trouble.
>
> Stefan
Leo
next prev parent reply other threads:[~2010-04-15 10:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-12 15:23 bug#5937: 23.1.95; why saving empty abbrev tables Leo
2010-04-12 18:32 ` Stefan Monnier
2010-04-15 10:26 ` Leo [this message]
2010-04-15 12:44 ` Stefan Monnier
2010-04-16 10:36 ` Leo
2010-04-27 3:49 ` Stefan Monnier
2010-04-27 8:46 ` Leo
2010-04-27 10:12 ` Leo
2010-04-27 10:32 ` Leo
2011-03-27 20:40 ` Stefan Monnier
2011-03-28 4:45 ` Leo
2011-03-28 13:58 ` Stefan Monnier
2011-03-28 14:26 ` Leo
2011-03-28 15:09 ` Stefan Monnier
2011-03-29 0:35 ` Leo
2011-03-29 3:31 ` Stefan Monnier
2011-03-29 4:41 ` Leo
2011-03-29 5:16 ` Leo
2011-03-29 13:49 ` Stefan Monnier
2011-03-29 15:42 ` Leo
2011-03-29 20:54 ` Stefan Monnier
2011-03-30 1:08 ` Leo
2011-03-27 5:09 ` Leo
2011-03-27 17:34 ` Andreas Röhler
2011-03-28 3:38 ` Leo
2011-03-27 20:35 ` Stefan Monnier
2011-03-28 4:03 ` Leo
2011-03-28 14:02 ` Stefan Monnier
2011-03-28 14:40 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xbaiwrw9j9jk.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=5937@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.