all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: bug#4994: 23.1.50; reftex-isearch-minor-mode does not restore to the original point
Date: Fri, 20 Nov 2009 22:44:15 +0000	[thread overview]
Message-ID: <xbair5rsx1ds.fsf@cam.ac.uk> (raw)
In-Reply-To: 87zl6hq8h1.fsf@mail.jurta.org

Hi Juri,

On 2009-11-20 19:32 +0000, Juri Linkov wrote:
> Multi-buffer isearch has no chance to save the initial state because
> its setup is called too late - after the initial state (without
> additional information about the original buffer) is pushed to the stack.
>
> IOW, in `isearch-mode', `(isearch-push-state)' is called earlier than
> (run-hooks 'isearch-mode-hook) that sets up multi-buffer specific
> `isearch-push-state-function'.
>
> Changing the order of these lines fixes this bug.  However, this change has
> a risk of breaking other things.  So I need more time to test this fix.

Thank you for fixing the issue. I will wait for your final patch ;)

Best wishes,
Leo







  reply	other threads:[~2009-11-20 22:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87ocmase6l.fsf@mail.jurta.org>
2009-11-20 17:34 ` bug#4994: 23.1.50; reftex-isearch-minor-mode does not restore to the original point Leo
2009-11-20 19:08   ` Juri Linkov
2009-11-20 19:32     ` Juri Linkov
2009-11-20 22:44       ` Leo [this message]
2009-12-07 17:30   ` Juri Linkov
2009-12-07 19:29     ` Leo
2009-12-07 20:55   ` bug#4994: marked as done (23.1.50; reftex-isearch-minor-mode does not restore to the original point) Emacs bug Tracking System

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xbair5rsx1ds.fsf@cam.ac.uk \
    --to=sdl.web@gmail.com \
    --cc=4994@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.