bug#5935: 23.1.95; pcomplete/cvs no longer works

bug#5935: 23.1.95; pcomplete/cvs no longer works

[Leo]

Firing up eshell and type 'cvs TAB' to get an error.

The arguments to pcomplete-here* seem changed making pcomplete/cvs to fail.

bug#5935: 23.1.95; pcomplete/cvs no longer works

[Stefan Monnier]

> Firing up eshell and type 'cvs TAB' to get an error.
> The arguments to pcomplete-here* seem changed making pcomplete/cvs to fail.

Thanks, it was a misread.  I've just installed the patch below (which
reverts part of an earlier change) which seems to fix it.


        Stefan


=== modified file 'lisp/pcomplete.el'
--- lisp/pcomplete.el	2010-01-13 08:35:10 +0000
+++ lisp/pcomplete.el	2010-04-13 01:21:54 +0000
@@ -1113,7 +1113,7 @@
 (defmacro pcomplete-here* (&optional form stub form-only)
   "An alternate form which does not participate in argument paring."
   (declare (debug t))
-  `(pcomplete-here (lambda () ,form) ,stub t ,form-only))
+  `(pcomplete-here ,form ,stub t ,form-only))
 
 ;; display support
 

bug#5935: 23.1.95; pcomplete/cvs no longer works

[Leo]

On 2010-04-13 02:26 +0100, Stefan Monnier wrote:
>> Firing up eshell and type 'cvs TAB' to get an error.
>> The arguments to pcomplete-here* seem changed making pcomplete/cvs to fail.
>
> Thanks, it was a misread.  I've just installed the patch below (which
> reverts part of an earlier change) which seems to fix it.
>

'cvs TAB' in eshell still throws error:

Debugger entered--Lisp error: (wrong-number-of-arguments #[nil "\300
\207" [pcmpl-cvs-commands] 1] 3)
  #[nil "\300 \207" [pcmpl-cvs-commands] 1]("" nil t)
  all-completions("" #[nil "\300 \207" [pcmpl-cvs-commands] 1])
  (let* ((completion-ignore-case pcomplete-ignore-case) (completions
  ...) (entry ...) result) (cond (... ...) (... ... ... ...) (... ...)
  (... ...) (... ... ...) (... ... ...) (t ... ...)) (cons result
  entry))
  pcomplete-stub("" #[nil "\300 \207" [pcmpl-cvs-commands] 1])
  pcomplete-do-complete("" #[nil "\300 \207" [pcmpl-cvs-commands] 1])
  byte-code("\306\211\306\211306\211

>
>         Stefan
>
>
> === modified file 'lisp/pcomplete.el'
> --- lisp/pcomplete.el	2010-01-13 08:35:10 +0000
> +++ lisp/pcomplete.el	2010-04-13 01:21:54 +0000
> @@ -1113,7 +1113,7 @@
>  (defmacro pcomplete-here* (&optional form stub form-only)
>    "An alternate form which does not participate in argument paring."
>    (declare (debug t))
> -  `(pcomplete-here (lambda () ,form) ,stub t ,form-only))
> +  `(pcomplete-here ,form ,stub t ,form-only))
>  
>  ;; display support

bug#5935: 23.1.95; pcomplete/cvs no longer works

[Leo]

On 2010-04-24 15:22 +0100, Leo wrote:
> 'cvs TAB' in eshell still throws error:

Sorry for this false alarm. It is indeed fixed. But unfortunately the
install process does not recompile the stale .elc files. I have just
done so and the bug is fixed.

Leo