Re: emacs/lisp ChangeLog font-lock.el

Re: emacs/lisp ChangeLog font-lock.el

[Leo]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On 2009-08-02 15:20 +0100, Chong Yidong wrote:
> CVSROOT:	/sources/emacs
> Module name:	emacs
> Changes by:	Chong Yidong <cyd>	09/08/02 14:20:12
>
> Modified files:
> 	lisp           : ChangeLog font-lock.el 
>
> Log message:
> 	* font-lock.el (font-lock-string-face, font-lock-builtin-face)
> 	(font-lock-variable-name-face, font-lock-constant-face): Darken
> 	the colors for light backgrounds.

This change seems to be pretty bad. see this attached screenshot.


[-- Attachment #2: font-lock.png --]
[-- Type: image/png, Size: 75346 bytes --]

[-- Attachment #3: Type: text/plain, Size: 65 bytes --]


-- 
Leo's Emacs uptime: 6 days, 14 hours, 5 minutes, 24 seconds

Re: emacs/lisp ChangeLog font-lock.el

[Stefan Monnier]

> This change seems to be pretty bad. see this attached screenshot.

Please explain what you don't like about it.
To me it looks like a good example of why this change was made: the new
colors have more contrast and make it easier to read the text even in
low-contrast situations (e.g. when you're trying to minimize battery
use).  Yes, it makes it more difficult to distinguish the different
colors used for different parts of the text.  But since font-lock is
enabled by default, the most important aspect is that the text
be legible.  If you want more contrast, then you'll need/want to
customize the colors.


        Stefan "who still thinks the exlcusive use of colors in
                font-lock faces is a big mistake.  Bold and italics
                give us a lot more room to maneuver, why not use them?"

Re: emacs/lisp ChangeLog font-lock.el

[Leo]

On 2009-08-10 16:30 +0100, Stefan Monnier wrote:
>> This change seems to be pretty bad. see this attached screenshot.
>
> Please explain what you don't like about it. To me it looks like a
> good example of why this change was made: the new colors have more
> contrast and make it easier to read the text even in low-contrast
> situations (e.g. when you're trying to minimize battery use).

Do you mean running on battery for laptops? I only test the colours on a
Macbook.

> Yes, it makes it more difficult to distinguish the different colors
> used for different parts of the text. But since font-lock is enabled
> by default, the most important aspect is that the text be legible. If
> you want more contrast, then you'll need/want to customize the colors.

I find the string and keyword colors look too alike.

>         Stefan "who still thinks the exlcusive use of colors in
>                 font-lock faces is a big mistake.  Bold and italics
>                 give us a lot more room to maneuver, why not use them?"

-- 
Leo's Emacs uptime: 6 days, 15 hours, 56 minutes, 29 seconds

Re: emacs/lisp ChangeLog font-lock.el

[Lennart Borgman]

On Mon, Aug 10, 2009 at 6:09 PM, Leo<sdl.web@gmail.com> wrote:

> I find the string and keyword colors look too alike.
>
>>         Stefan "who still thinks the exlcusive use of colors in
>>                 font-lock faces is a big mistake.  Bold and italics
>>                 give us a lot more room to maneuver, why not use them?"

There is a "rather" long thread about this here:

   http://lists.gnu.org/archive/html/emacs-devel/2009-07/msg01598.html

and there is a place on EmacsWiki where you can put suggestions (for
colors, maybe I should add bold and italic as Stefan suggests we
should use them too...):

  http://lists.gnu.org/archive/html/emacs-devel/2009-07/msg01598.html