all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo <sdl.web@gmail.com>
To: bug-gnu-emacs@gnu.org
Subject: bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands
Date: Tue, 04 May 2010 14:41:11 +0100	[thread overview]
Message-ID: <xbai7hnjdbt4.fsf@cam.ac.uk> (raw)
In-Reply-To: <m1r5lueliy.fsf@cam.ac.uk>

On 2010-05-02 10:01 +0100, Leo wrote:
> Please review the attached patch instead which fixed compiler warnings
> in the previous patch.
>
> Thanks.
> Leo

This patch make sures commands defined by rcirc are seen first before
server commands.

Leo

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index 2e5e7ac..9b58112 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -800,9 +800,9 @@ IRC command completion is performed only if '/' is the first input char."
              (if (and (zerop rcirc-completion-start-offset)
                       (char-after rcirc-prompt-end-marker)
                       (= (char-after rcirc-prompt-end-marker) ?/))
-                 (sort (delete-dups (append rcirc-client-commands
-                                            (copy-sequence rcirc-server-commands)))
-                       'string-lessp)
+                 (delete-dups
+                  (append (sort (copy-sequence rcirc-client-commands) 'string-lessp)
+                          (sort (copy-sequence rcirc-server-commands) 'string-lessp)))
                (mapcar (lambda (x) (cons x nil))
                        (rcirc-channel-nicks (rcirc-buffer-process)
                                             rcirc-target)))))))









  reply	other threads:[~2010-05-04 13:41 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-02  8:49 bug#6076: 23.1.96; [PATCH] rcirc-complete for nicks and commands Leo
2010-05-02  9:01 ` Leo
2010-05-04 13:41   ` Leo [this message]
2010-05-03 16:37 ` Stefan Monnier
2010-05-03 17:45   ` Leo
2010-05-04  2:32     ` Stefan Monnier
2010-05-04 16:18       ` Juri Linkov
2010-05-04 18:29         ` Stefan Monnier
2010-05-04 20:01           ` Juri Linkov
2010-05-04 21:18             ` Stefan Monnier
2010-05-10 19:14               ` Juri Linkov
2010-05-11  1:14                 ` Stefan Monnier
2010-05-11 16:54                   ` Juri Linkov
2010-05-11 19:52                     ` Stefan Monnier
2010-08-23 10:36 ` Leo
2010-09-03 22:13 ` Ryan Yeske
2010-09-04  8:24   ` Stefan Monnier
2010-09-04 10:21     ` Leo
2010-09-04 21:44       ` Stefan Monnier
2010-09-06 17:52         ` Leo
2010-09-11 12:55           ` Stefan Monnier
2010-09-11 13:03             ` Leo
2010-09-12 11:11               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xbai7hnjdbt4.fsf@cam.ac.uk \
    --to=sdl.web@gmail.com \
    --cc=bug-gnu-emacs@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.