From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: [patch] convert footnote.el to use define-minor-mode Date: Sat, 04 Jul 2009 17:03:56 +0100 Message-ID: References: <86d4fx82jd.fsf@nirvana.pusto.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1246723674 27580 80.91.229.12 (4 Jul 2009 16:07:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Jul 2009 16:07:54 +0000 (UTC) Cc: Eduard Wiebe , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 04 18:07:47 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MN7mE-0005QQ-Js for ged-emacs-devel@m.gmane.org; Sat, 04 Jul 2009 18:07:46 +0200 Original-Received: from localhost ([127.0.0.1]:49451 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MN7mD-0008QC-SB for ged-emacs-devel@m.gmane.org; Sat, 04 Jul 2009 12:07:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MN7ij-0003mA-R5 for emacs-devel@gnu.org; Sat, 04 Jul 2009 12:04:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MN7if-0003kD-0I for emacs-devel@gnu.org; Sat, 04 Jul 2009 12:04:09 -0400 Original-Received: from [199.232.76.173] (port=48461 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MN7ie-0003k7-Nu for emacs-devel@gnu.org; Sat, 04 Jul 2009 12:04:04 -0400 Original-Received: from ppsw-7.csi.cam.ac.uk ([131.111.8.137]:41571) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MN7id-0007P1-TZ for emacs-devel@gnu.org; Sat, 04 Jul 2009 12:04:04 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:41578) by ppsw-7.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.157]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES256-SHA:256) id 1MN7iW-00046c-Oc (Exim 4.70) (return-path ); Sat, 04 Jul 2009 17:03:56 +0100 In-Reply-To: (Stefan Monnier's message of "Fri, 12 Dec 2008 22:13:46 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:112016 Archived-At: On 2008-12-13 03:13 +0000, Stefan Monnier wrote: >> 2008-12-12 Eduard Wiebe > >> * mail/footnote.el (footnote-mode): Use define-minor-mode >> (footnote-prefix): Use defcustom > > Looks very good, thank you. Except you've renamed footnote-prefix to > footnote-mode-prefix, which doesn't seem to be worth the trouble (of > and ChangeLog text should end with "."). > > > Stefan On 2008-12-13 23:46 +0000, Eduard Wiebe wrote: [...] > Stefan, thank you for comments. > > 2008-12-14 Eduard Wiebe > > * mail/footnote.el (footnote-mode): Use define-minor-mode. > (footnote-prefix): Use defcustom. > [...] May it be possible for this patch to be applied to trunk? The current footnote leaks a few key bindings globally and it can be a surprise to see them when in a mode without footnote enabled. Thank you. -- Leo's Emacs uptime: 24 days, 2 hours, 19 minutes, 34 seconds