From: Leo <sdl.web@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Eduard Wiebe <usenet@pusto.de>, emacs-devel@gnu.org
Subject: Re: [patch] convert footnote.el to use define-minor-mode
Date: Sat, 04 Jul 2009 17:03:56 +0100 [thread overview]
Message-ID: <xbai63e8l9jn.fsf@cam.ac.uk> (raw)
In-Reply-To: <jwvhc584vn1.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 12 Dec 2008 22:13:46 -0500")
On 2008-12-13 03:13 +0000, Stefan Monnier wrote:
>> 2008-12-12 Eduard Wiebe <usenet@pusto.de>
>
>> * mail/footnote.el (footnote-mode): Use define-minor-mode
>> (footnote-prefix): Use defcustom
>
> Looks very good, thank you. Except you've renamed footnote-prefix to
> footnote-mode-prefix, which doesn't seem to be worth the trouble (of
> and ChangeLog text should end with ".").
>
>
> Stefan
On 2008-12-13 23:46 +0000, Eduard Wiebe wrote:
[...]
> Stefan, thank you for comments.
>
> 2008-12-14 Eduard Wiebe <usenet@pusto.de>
>
> * mail/footnote.el (footnote-mode): Use define-minor-mode.
> (footnote-prefix): Use defcustom.
>
[...]
May it be possible for this patch to be applied to trunk? The current
footnote leaks a few key bindings globally and it can be a surprise to
see them when in a mode without footnote enabled. Thank you.
--
Leo's Emacs uptime: 24 days, 2 hours, 19 minutes, 34 seconds
prev parent reply other threads:[~2009-07-04 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 22:13 [patch] convert footnote.el to use define-minor-mode Eduard Wiebe
2008-12-13 3:13 ` Stefan Monnier
2008-12-13 23:46 ` Eduard Wiebe
2009-01-02 18:21 ` Leo
2009-07-04 16:03 ` Leo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xbai63e8l9jn.fsf@cam.ac.uk \
--to=sdl.web@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=usenet@pusto.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.