From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.bugs Subject: bug#4308: 23.1.50; patch: fix `eshell-history-file-name' Date: Tue, 01 Sep 2009 20:49:59 +0100 Message-ID: References: Reply-To: Leo , 4308@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1251835709 23295 80.91.229.12 (1 Sep 2009 20:08:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Sep 2009 20:08:29 +0000 (UTC) To: 4308@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 01 22:08:22 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MiZeP-0001hr-QV for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2009 22:08:22 +0200 Original-Received: from localhost ([127.0.0.1]:43080 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiZeL-0000jI-QA for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Sep 2009 16:08:17 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MiZdA-0000Ne-En for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 16:07:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MiZd5-0000KP-Jl for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 16:07:03 -0400 Original-Received: from [199.232.76.173] (port=55206 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MiZd4-0000KH-Vc for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 16:06:58 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53620) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MiZd4-0005VD-Dh for bug-gnu-emacs@gnu.org; Tue, 01 Sep 2009 16:06:58 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81K6tGe008807; Tue, 1 Sep 2009 13:06:56 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n81Jt5Hf005788; Tue, 1 Sep 2009 12:55:05 -0700 Resent-Date: Tue, 1 Sep 2009 12:55:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Leo Original-Sender: "Leo, Shidai Liu" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Tue, 01 Sep 2009 19:55:05 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 4308 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 4308-submit@emacsbugs.donarmstrong.com id=B4308.12518346034745 (code B ref 4308); Tue, 01 Sep 2009 19:55:05 +0000 Original-Received: (at 4308) by emacsbugs.donarmstrong.com; 1 Sep 2009 19:50:03 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from ppsw-5.csi.cam.ac.uk (ppsw-5.csi.cam.ac.uk [131.111.8.135]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n81Jo0mA004688 for <4308@emacsbugs.donarmstrong.com>; Tue, 1 Sep 2009 12:50:03 -0700 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Original-Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:60876) by ppsw-5.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.155]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1MiZMe-0008QI-GR (Exim 4.70) for 4308@emacsbugs.donarmstrong.com (return-path ); Tue, 01 Sep 2009 20:50:00 +0100 In-Reply-To: (Leo's message of "Tue, 01 Sep 2009 20:32:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Resent-Date: Tue, 01 Sep 2009 16:07:03 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:30714 Archived-At: On 2009-09-01 20:32 +0100, Leo wrote: > The attached small patch makes eshell-history-file-name more robust. For > example, I accidentally set eshell-directory-name to ~/.emacs.d/shell > without a trailing / and the history was written to > ~/.emacs.d/shellhistory. Please also fix the following places: em-alias.el.gz:105:(defcustom eshell-aliases-file (concat eshell-directory-name "alias") em-dirs.el.gz:141: (concat eshell-directory-name "lastdir") em-script.el.gz:43:(defcustom eshell-login-script (concat eshell-directory-name "login") em-script.el.gz:50:(defcustom eshell-rc-script (concat eshell-directory-name "profile") Thank you. -- Leo's Emacs uptime: 10 days, 1 hour, 21 minutes, 12 seconds