From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv3 0/3] Add `notes' function, take three Date: Fri, 21 Jun 2013 19:13:26 +0200 Organization: http://mina86.com/ Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1371834831 29259 80.91.229.3 (21 Jun 2013 17:13:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 21 Jun 2013 17:13:51 +0000 (UTC) Cc: Juanma Barranquero , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 21 19:13:52 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uq4uF-0007Es-2q for ged-emacs-devel@m.gmane.org; Fri, 21 Jun 2013 19:13:51 +0200 Original-Received: from localhost ([::1]:35101 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq4uE-0006IB-L2 for ged-emacs-devel@m.gmane.org; Fri, 21 Jun 2013 13:13:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq4u7-0006Gn-63 for emacs-devel@gnu.org; Fri, 21 Jun 2013 13:13:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uq4u2-00008V-NF for emacs-devel@gnu.org; Fri, 21 Jun 2013 13:13:43 -0400 Original-Received: from mail-ea0-x229.google.com ([2a00:1450:4013:c01::229]:44854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uq4u2-00008C-DO for emacs-devel@gnu.org; Fri, 21 Jun 2013 13:13:38 -0400 Original-Received: by mail-ea0-f169.google.com with SMTP id h15so4784233eak.14 for ; Fri, 21 Jun 2013 10:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash:x-hashcash :x-hashcash:date:message-id:mime-version:content-type; bh=qZzu/DLqcYa+UnG+dbWGltpO/NWG47MHya7eIa2OWLc=; b=RqoGwZf7exC3LqpE5/ribYvGZV1z2zbuTe/vJwCiH2OfRsiuZDatK7huTGpfENrwMq DRXGtbvrHl2X+//+KNd7/qosaqwU2T26gStYV61rlOZDnkOLkadkWhFhMWkCvUI5rpnq OWildiZkD6NVqdRuEw86NKkpmDgxojq1TAERqokcfGucLgDidgd24gcxVWFqcHAOJ+Cp /iwY8G84jrtx//EvR4lkTWfjSe1ov+eBCCuC73QeVqkFryVO9RvlU/bUvEs7zH1mNGKa Qwu6BJMKVuuXEVoniIJ2jkolbaZBy+MxCndh65EjHVt0hqbThKdwPjwA0jqWTYP8kQc6 kiSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash:x-hashcash :x-hashcash:date:message-id:mime-version:content-type :x-gm-message-state; bh=qZzu/DLqcYa+UnG+dbWGltpO/NWG47MHya7eIa2OWLc=; b=mK1uBxfhEc/NHidi9XGJD1PK3MDTPz11kvcSnJY660L+kb2yaq3JXxW9VHFcnvvcmm /5XiEZrfg7yAhtzMLu3pXjSa+/TrAgsh/v41Hv9Yf4NI6g1rH3tDgWJUwiC2XCoB2meU CKO4Rv5vV3HZJ2OrVmQ6uljnq1I6SME9W+mKba+ye3UCJL9kubk3iNh3KyUS7crDEg+F FzIZykZg0h0EFLn6hMA3b1GH5n4ZL7ZK12ZaN5gOr/V/TIP2jZUGoInBB5P3RPuHUgjv udV3qydkEpIbH9dV/PaZbVwSgRp5JOBwX3wBAg1EjeuqByEDevT9UcM8xkFAh0dhMSHI Ysdw== X-Received: by 10.14.206.196 with SMTP id l44mr11172985eeo.142.1371834817642; Fri, 21 Jun 2013 10:13:37 -0700 (PDT) Original-Received: from mpn-glaptop ([2620:0:105f:301:9083:48af:8870:116f]) by mx.google.com with ESMTPSA id c44sm9062915eeb.8.2013.06.21.10.13.34 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 21 Jun 2013 10:13:35 -0700 (PDT) In-Reply-To: User-Agent: Notmuch/0.15.2+55~geb6e9d8 (http://notmuchmail.org) Emacs/24.3.50.3 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR 4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:130621:lekktu@gmail.com::hZZAi9q3F8Q2O309:00jR0 X-Hashcash: 1:20:130621:monnier@iro.umontreal.ca::Eqt2E8bXZ10575kF:00000000000000000000000000000000000009rPl X-Hashcash: 1:20:130621:emacs-devel@gnu.org::UU2BbOFz71Gghcf2:000000000000000000000000000000000000000000DGdS X-Gm-Message-State: ALoCoQn1fqMJCSOvu6h5DlfDOkExsDZbnm0FYhhvd5ivAkRussHHPE0fIIvKFKgZpQNtlEPmX/5fCXZven0j7QvTM//JEtTopO8eimbznwfqp9I1zt7AwKzbeW6Dpnpn1Pd2TOEiEYvDJUrJ3oTMY2+6pLFSNzUS38k0IEzxtZQpIqrZQ3QtuOq0Ppf0v6Kq8+eFh9lkEOZWvOcdSZXgG5qZ+4+Z08glwg== X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160847 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri, Jun 21 2013, Stefan Monnier wrote: >> Change to kill-buffer allowed an advice to be replaced with a hook, > > OK > >> and after looking more closely at remember.el, I think notes might be >> a good fit for it. > > Indeed. Why even define a separate notes-file? I wanted to keep it as an option for people who would like to use remember to store data in notes file which then gets processed somehow (I've never used remember before now, so I'm not sure what that could involve) while use notes for some random data. As far as *I'm* concerned, I can leave w/o notes-file and just remember-data-file. > And why not use (find-file-noselect notes-file), maybe followed by > a rename-buffer? I'll take a look at it. >> Stefan, are you still not convinced, and prefer to have it in ELPA >> after all? > > No, I think remember.el is a good place for it. It would also be good > to use the "remember-" prefix. Will do. >> The second patch is actually unrelated, but something I've noticed >> while playing with notes. > > Good point. I think we should turn get-file-buffer into an alias for > find-buffer-visiting. $ grep find-buffer-visiting $(grep -Rl get-file-buffer **/*.el) |wc -l 43 so it seems that in most cases code sticks to either of the two functions, and some of the above occurrences are XEmacs compatibility functions, comments, and situations where it would seem that the code could be easily converted to stick to find-buffer-visiting. So yeah, I guess it is doable. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJRxIm3AAoJECBgQBJQdR/0evUP/2EgAII8SRuJhP1S62KEswEG gQhkEOe49JDd+I+Qn3ww+Lg3+p0R8Ij7shcfjA21cEpPtXyAldXpJCtsUPIxWWrC 4b3V98H8VfQBS1NZ/hSN2Nm0Z7KXj0kbMHXV69hKZeVa5Ul7idEjsh7nCKom1VY/ 3EKjzfa3OAWF/NiAr04p7XZJMKm4jYFD7JlvYxOj5z4bCtRebyYRwFifsj/68hby 1SFEU2VUtMdDH4UpMRGugSv/MHTmKptOZ5wpVRLlXIKpN1DB6vX9xrEZZJSv0Vhu 3a27ja7UH2v2dzNkmglZkuUiH9BTn7faBYbnwetwjHGTgXngawULkwMCbzdn3JxO j7vWWBS7pdxcFchxQXcutO1KIwbDjAT4hovxOML1LUFD5cGfFou1rtf0f964wrjY NRc9qkgfB+yO/0L/Ip1tZ9siE4rYTU6ckCV+Hoko463krtwcmguPuDHBKCH31Etk mHD3gEGupbpKunO5qWgGqzZ8jbkeuLbsI+TdNq6Ih+2P3si9kz/5ry5LKA82+Fke Oj4dLupwLumdmV4lCcQSpVNLMXMwyRsccfA5nTwPOemNbh6uZkhlqDjJoJ8cY6M6 66C4WrVu/n95Od3/LNHHwh9VL9UxLNlV5EkZ87sZYsAuatvP32bAmBphTXkQsQgn Pxf5Ggic9ZY3+6gIPNGM =jAkO -----END PGP SIGNATURE----- --==-=-=-- --=-=-=--