From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.devel Subject: Re: PATCH: num3-mode for highlighting groups of digits in long numbers Date: Wed, 26 Sep 2012 23:33:03 +0200 Organization: Google Inc Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1348695210 14682 80.91.229.3 (26 Sep 2012 21:33:30 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Sep 2012 21:33:30 +0000 (UTC) Cc: Noah Lavine , emacs-devel@gnu.org, Felix Lee To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 26 23:33:35 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TGzEc-0005VZ-Ny for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2012 23:33:34 +0200 Original-Received: from localhost ([::1]:33497 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGzEX-0001W0-Nr for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2012 17:33:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59376) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGzEQ-0001Nj-D4 for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:33:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGzEL-0004hn-Ht for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:33:22 -0400 Original-Received: from mail-wg0-f49.google.com ([74.125.82.49]:40968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGzEK-0004eH-TW for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:33:17 -0400 Original-Received: by wgbdt14 with SMTP id dt14so636555wgb.30 for ; Wed, 26 Sep 2012 14:33:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:in-reply-to:organization:references:user-agent :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version :content-type; bh=5F7rxAucXGvGAMq6gjqWxRgsEU0xhX9WLnYpl4CWhRg=; b=AmmBf2L/wFQRx9FPh01Io7bMR85iDmgi2eAfu0bHY50E6r4x7KOW223ZwnGyfqwKa5 xapRUPoY9sJRobXRGZENifZRM+gFZqzu0urI3K2aDpYUTi+90OfIM+Es5IQvD2hac0oR 9fx7Dtn1BCE88p5K3Be4OZp0xf2o2Sk3WgGPF3+uXd3IrR1KXl5UZ76Zf7iT1CGMgBd3 fSCwjKlxD55GqCd37dDb/ukaeVaFy5ENv9YBDd7u8WxMasBa3NIlhcpvw1+aQE3r6gxU 9D82DceE2wjShrnwYsYKx23dNqwez7tMseQ6tjqfn0K7j5ZsAcaIC1485p658fz7cCx9 XTpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:in-reply-to:organization:references:user-agent :x-face:face:x-pgp:x-pgp-fp:date:message-id:mime-version :content-type:x-gm-message-state; bh=5F7rxAucXGvGAMq6gjqWxRgsEU0xhX9WLnYpl4CWhRg=; b=pQmcLJeBBsB0Vr+nlHkY+SzuhwgNhMvLSWi3CjaTIfo5fbvUZbTTUcBv5rilS+Z1BN le9YEIkAr3Hbv5mUJfA5Ycf9NwgwVN7QfZAftn0cFMXJLel50GWe00xCbfOm4mjD22GT 1anwKdkVeMIZLIlSM8w68rcYXETZvqAei2vECHuCQbuOKnEsGAPJcHBCT+sbKqNgIAMs Eq2E9Yl7bQ3qFdmRYAswIFFMmCXtherBmxYTmHDQYFd9xkzWpsk2Nv0IiDjCfV/XtkEJ GAolYZwdQmT/V18OyBvAQDQqBfnZJSj68PeIAFfkvKm0EMWnlA92cdhM2SKvfgE+cBA7 O/TQ== Original-Received: by 10.180.79.100 with SMTP id i4mr511799wix.12.1348695192516; Wed, 26 Sep 2012 14:33:12 -0700 (PDT) Original-Received: by 10.180.79.100 with SMTP id i4mr511779wix.12.1348695192360; Wed, 26 Sep 2012 14:33:12 -0700 (PDT) Original-Received: from mpn-glaptop ([172.28.91.155]) by mx.google.com with ESMTPS id l6sm27771359wiz.4.2012.09.26.14.33.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 26 Sep 2012 14:33:10 -0700 (PDT) In-Reply-To: User-Agent: Notmuch/0.14+22~g8bdc16b (http://notmuchmail.org) Emacs/24.2.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR 4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Gm-Message-State: ALoCoQnfnCgoBuHgCb4OrcZz3ETRDHu+2im0etNzYU/HCkr7XHWSflkmIxLq43h4KjttYLgmHrKoP+wO1jrCJXkNilz5l7asUsbpTGEmhFrfD8OviupdLZvYze3urj+/SSZHjhfQqYxVqWlItYXlMxGbVEcz0lJPmlNvHOsegO9USzM6QfXw0FbZYJB11EvzYrkz4V9NLVg/Hx9I+D25nS4lbYOryccHLQ== X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.82.49 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153607 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Wed, Sep 26 2012, Stefan Monnier wrote: >> Sorry, you're absolutely right. It's mistake in documentation in my >> part. Attached is fixed version of the file. > > Thanks, I just added it to the `elpa' so it should appear in GNU ELPA > next time someone refreshes it. > > I made the following changes: > - Added a "Version: 1.0" header. Ah, thanks. I've added the header at one point but must have removed it by mistake during subsequent edits. > - Removed the (require 'font-lock) that seemed unnecessary. Well, num3 does use some font-lock-* functions, but they may be autoloads or something. > - Removed turn-on-num3-mode since (num3-mode) does the same anyway. > I do see that when num3-mode is already enabled (turn-on-num3-mode) did > nothing whereas (num3-mode) will call font-lock-fontify-buffer but if > that's a problem, we should fix num3-mode. Uh? num3-mode properly toggles number highlighting for me. > I'm not sure what the "-num-" prefix is meant to be and I'm not fond > of it. If it's meant for internal functions, then please use > "num--" instead. Will do. >> checkdoc-current-buffer gives me two errors but I'm not sure how to fix >> those since in given instances num3-mode refers to the mode. > > Don't take checkdoc for the gospel; those "errors" are fine. > If you do want to fix them, do as told: add the word "function" or > "command" soon before the offending `num3-mode'. Yeah, I've decided that in this instance, I'm smarter than=20 > If you want to maintain the file directly in the elpa branch (rather > than send us patches), then please ask for write access (by registering > an account on savannah, and asking for membership in the "emacs" group > from that account). Will do. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJQY3SPAAoJECBgQBJQdR/05ykP/iHeUquRipyP4wLml8zM+YDQ zD0xIHsC9sUtuPcG4X4Lcf4SiKZjpdkS/q2LYIc9L+1P5uuEqSwBlSs3fD6ZUVfh 9rLK8H4HunymUBA4KKg9q8o4Lkp9j1vCzYjLN+HHj7500m/Ua3FNynU9xr9MFbHd 8OwB8cYC/SQtxQlCqszWwjvG6UaG2Lh/2Tnd3YPvUweLuzfKRi/+VYXpeYZL6npR UuRi5+2tjfIupHRjXXJ/1o0poVtsZmIkb3Jee5h1y///tNy57dyUf/5S75rb1ByH ofzxeju1GmYrYd0MNeSBhVeCK71wqxytQuhcT1O2JAgTOAA7cxPejnSQ1YWnlecD j5eRakXnFgcSm70VEoRfiohFLPDgkV51WjDtCv6ZgQ3RsrVL4lBftV7nTzQ4RQGU EWyQ9SMwCrw+IN2ndquytpa1jzS+60nVH5XVCvGveAqkxZxv2H1Ih0yktXcT8MaM Su+L/sorVsLtePIWHsbEKe0iIhLu9oZNLbeiwHE42wmO1Kd0+mSNod7jfRn80iS1 ybwA5fcn8SLnMGVffVXmH1OGiIOG6kP2IokKS93eTjdZLMcQK0FONDfnKfLhEOhu hQ1SzwP2JoJekG/tZw2GIC8Zdd5AcUx7UCl7t7va1qJCOoFBhmyNVLcG6DogmR+5 THJFrC/kEQttxKD0w4aq =K2G9 -----END PGP SIGNATURE----- --==-=-=-- --=-=-=--