From: Glenn Morris <rgm@gnu.org>
To: jostein@kjonigsen.net
Cc: emacs-devel@gnu.org
Subject: Re: cl-macro-expandall symbol definition is void
Date: Tue, 25 Nov 2014 17:35:46 -0500 [thread overview]
Message-ID: <x8uiygb7h.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <8mvbm3vsii.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 25 Nov 2014 17:12:53 -0500")
Following diff seems to make csharp-mode-0.8.5.el work fine for me.
(Without the `eval-and-compile', it was uncompilable in any Emacs 24.x.)
Since it uses eg `set-difference', IMO it should in any case explicitly
require cl and not rely on its other dependencies pulling it in.
*** csharp-mode-0.8.5.el.ORIG 2014-11-25 14:32:22.001787092 -0800
--- csharp-mode-0.8.5.el 2014-11-25 14:31:13.608157922 -0800
***************
*** 379,384 ****
--- 379,385 ----
;; 0.8.6 DPC 2011 May ??
;; -
+ (eval-when-compile (require 'cl))
(require 'cc-mode)
***************
*** 472,477 ****
--- 473,479 ----
"Regex for matching directive blocks in ASP.NET files (.aspx, .ashx, .ascx)")
+ (eval-and-compile
(defconst csharp-enum-decl-re
(concat
"\\<enum[ \t\n\r\f\v]+"
***************
*** 484,490 ****
"\\)"
"\\)?")
"Regex that captures an enum declaration in C#"
! )
;; ==================================================================
--- 486,492 ----
"\\)"
"\\)?")
"Regex that captures an enum declaration in C#"
! ))
;; ==================================================================
next prev parent reply other threads:[~2014-11-25 22:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 21:24 cl-macro-expandall symbol definition is void Jostein Kjønigsen
2014-11-25 22:12 ` Glenn Morris
2014-11-25 22:35 ` Glenn Morris [this message]
2014-11-26 8:22 ` Jostein Kjønigsen
2014-11-26 14:23 ` Stefan Monnier
2014-11-27 9:58 ` Jostein Kjønigsen
2014-11-27 17:09 ` Stefan Monnier
2014-11-26 16:47 ` Glenn Morris
2014-11-26 18:41 ` Stefan Monnier
2014-11-26 21:34 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2014-10-20 22:37 covici
2014-10-21 0:18 ` Kelvin White
2014-10-21 1:45 ` covici
2014-10-21 5:33 ` Stephen J. Turnbull
2014-10-21 6:59 ` covici
2014-10-21 13:45 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x8uiygb7h.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=jostein@kjonigsen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.