Re: elisp macros problem

[David Kastrup <dak@gnu.org>]

Lowell Kirsh <lkirsh@cs.ubc.ca> writes:

> I am defining an emacs lisp macro to do:
> 
> (my-add-hook 'lisp
>     ...)
> 
> which should give:
> 
> (add-hook 'lisp-mode-hook
>    (lambda () ...))
> 
> I have:
> 
> (defmacro my-add-hook (hook &rest body)
>    (let ((tempvar (make-symbol "cat")))
>      `(flet ((,tempvar (sym str)
>                        (make-symbol (concat (symbol-name sym) str))))
>         (add-hook (cat ,hook "-mode-hook") (lambda () ,@body)))))
> 
> Does anyone know what's wrong with this and why it doesn't work?

I don't know where to start...

First of all, your use of flet is complete nonsense.  You flet an
uninterned symbol with the name "cat" to some function.  However, you
never use that function.  Instead you are trying to call the interned
symbol "cat" (which is probably undefined).  Even if one fixed that,
it is completely unnecessary.  Just do

(defmacro my-add-hook (hook &rest body)
  `(add-hook ',(intern (concat (symbol-name hook) "-mode-hook"))
        (lambda () ,@body)))

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum