Re: Is that change a good idea?

[David Kastrup <dak@gnu.org>]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> > 	* help.el (describe-mode): Allow a :minor-mode-function property to
>>> > 	specify a different minor mode toggle function than the variable.
>>> > 	* simple.el (auto-fill-function):
>>> > 	* subr.el (add-minor-mode): Use it.
>>> 
>>> > I have my doubts that the resulting flexibility is really in the best
>>> > interest of the users...
>>> 
>>> 100% agreement.
>>> It's only meant to clean up the code,
>
>> Wouldn't it be far more cleaner to convert old minor-modes which would
>> need this hack to proper minor-modes following standard semantics?
>
> You do realize that there are packages over which we have no
> control, right?

Well, then we won't need to worry about us not being able to use
define-minor-mode for them.

>  make sure they're kept in sync.  Maybe we could do (defvaralias
> 'auto-fill-function 'auto-fill-mode) and then slowly change modes to
> replace (if auto-fill-function (funcall auto-fill-function)) with
> (if auto-fill-mode (funcall normal-auto-fill-function)).

That won't work if modes set auto-fill-function themselves to a
function...

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum