From: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org, "Kim F. Storm" <storm@cua.dk>
Subject: Re: EWMH package, please review.
Date: 13 Oct 2003 09:54:41 +0200 [thread overview]
Message-ID: <x5ismtlghq.fsf@lola.goethe.zz> (raw)
In-Reply-To: <0864E46B-FD36-11D7-8B0B-00039363E640@swipnet.se>
"Jan D." <jan.h.d@swipnet.se> writes:
> >> ;;; Code:
> >>
> >> (defun x-ewmh-send (arg hint frame &optional hint2)
> >> "Send a client message to change an extended window manager hint.
> >>
> >> (let* ((eff-arg (if (null arg) 0 (prefix-numeric-value arg)))
> >
> > This is simpler:
> >
> > (setq arg (if (null arg) 0 (prefix-numeric-value arg)))
> > (let ((action ...use ARG instead of EFF-ARG...))
>
> I was told to avoid setq when I learned lisp :-).
And using setq on variables not supposed to be global and not having
a local binding either is quite a bad practice. In this case,
however, arg already _has_ a local binding from the defun.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2003-10-13 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-12 16:53 EWMH package, please review Jan D.
2003-10-12 22:17 ` Kim F. Storm
2003-10-12 22:54 ` Miles Bader
2003-10-13 4:34 ` Jan D.
2003-10-13 4:30 ` Jan D.
2003-10-13 7:54 ` David Kastrup [this message]
2003-10-13 8:43 ` Thien-Thi Nguyen
2003-10-18 17:47 ` Jan D.
2003-10-18 18:05 ` David Kastrup
2003-10-18 18:15 ` David Kastrup
2003-10-27 5:56 ` Jan D.
2003-10-13 18:21 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=x5ismtlghq.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.