* Problems with advice...
@ 2005-03-17 10:00 David Kastrup
2005-03-17 10:41 ` David Kastrup
2005-03-17 14:41 ` Stefan Monnier
0 siblings, 2 replies; 3+ messages in thread
From: David Kastrup @ 2005-03-17 10:00 UTC (permalink / raw)
I have the problem that preactivated advice no longer gets
preactivated. However, the same problem occurs now with a current
compilation of Emacs-21.3! So I suspect that it might be
compiler-related (gcc-4.0). It worked at one point of time in the
past.
Whatever. In the search for the problem I have also come across the
following code snippet in advice.el:
((and orig-subr-p
orig-interactive-p
(not interactive-form)
(not advised-interactive-form))
;; Check whether we were called interactively
;; in order to do proper prompting:
`(if (called-interactively-p)
(call-interactively ',origname)
,(ad-make-mapped-call orig-arglist
advised-arglist
origname)))
;; And now for normal functions and non-interactive subrs
;; (or subrs whose interactive behavior was advised):
(t (ad-make-mapped-call
advised-arglist orig-arglist origname)))))
This looks so wrong that I want somebody with more of a clue to take a
look at it: ad-make-mapped-call is called in two branches of a cond,
and the order of its first two arguments is interchanged in those two
calls!
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problems with advice...
2005-03-17 10:00 Problems with advice David Kastrup
@ 2005-03-17 10:41 ` David Kastrup
2005-03-17 14:41 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: David Kastrup @ 2005-03-17 10:41 UTC (permalink / raw)
David Kastrup <dak@gnu.org> writes:
> I have the problem that preactivated advice no longer gets
> preactivated. However, the same problem occurs now with a current
> compilation of Emacs-21.3! So I suspect that it might be
> compiler-related (gcc-4.0). It worked at one point of time in the
> past.
Update on that: seemingly related to loading a completely unrelated
package (that does a "require" on the file containing the function to
be advised), so not a compiler error after all. I have to debug this
further.
In the mean time, the following finding still looks bad:
> Whatever. In the search for the problem I have also come across the
> following code snippet in advice.el:
>
> ((and orig-subr-p
> orig-interactive-p
> (not interactive-form)
> (not advised-interactive-form))
> ;; Check whether we were called interactively
> ;; in order to do proper prompting:
> `(if (called-interactively-p)
> (call-interactively ',origname)
> ,(ad-make-mapped-call orig-arglist
> advised-arglist
> origname)))
> ;; And now for normal functions and non-interactive subrs
> ;; (or subrs whose interactive behavior was advised):
> (t (ad-make-mapped-call
> advised-arglist orig-arglist origname)))))
>
> This looks so wrong that I want somebody with more of a clue to take a
> look at it: ad-make-mapped-call is called in two branches of a cond,
> and the order of its first two arguments is interchanged in those two
> calls!
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problems with advice...
2005-03-17 10:00 Problems with advice David Kastrup
2005-03-17 10:41 ` David Kastrup
@ 2005-03-17 14:41 ` Stefan Monnier
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2005-03-17 14:41 UTC (permalink / raw)
Cc: emacs-devel
> This looks so wrong that I want somebody with more of a clue to take a
> look at it: ad-make-mapped-call is called in two branches of a cond,
> and the order of its first two arguments is interchanged in those two
> calls!
I think the patch below is the right one,
Stefan
--- orig/lisp/emacs-lisp/advice.el
+++ mod/lisp/emacs-lisp/advice.el
@@ -3108,8 +3108,8 @@
;; in order to do proper prompting:
`(if (called-interactively-p)
(call-interactively ',origname)
- ,(ad-make-mapped-call orig-arglist
- advised-arglist
+ ,(ad-make-mapped-call advised-arglist
+ orig-arglist
origname)))
;; And now for normal functions and non-interactive subrs
;; (or subrs whose interactive behavior was advised):
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-17 14:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-03-17 10:00 Problems with advice David Kastrup
2005-03-17 10:41 ` David Kastrup
2005-03-17 14:41 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.