From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Suggested change in net/browse-url.el Date: 01 Apr 2004 19:24:50 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1080842166 26007 80.91.224.253 (1 Apr 2004 17:56:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 1 Apr 2004 17:56:06 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Apr 01 19:55:59 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B96Q3-0003Wu-00 for ; Thu, 01 Apr 2004 19:55:59 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B96Q2-0003AG-00 for ; Thu, 01 Apr 2004 19:55:59 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B96Pv-0000G3-RQ for emacs-devel@quimby.gnus.org; Thu, 01 Apr 2004 12:55:51 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B96PS-0000B3-Ch for emacs-devel@gnu.org; Thu, 01 Apr 2004 12:55:22 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B96Ow-0008UZ-CB for emacs-devel@gnu.org; Thu, 01 Apr 2004 12:55:21 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B95vv-00053Y-74 for emacs-devel@gnu.org; Thu, 01 Apr 2004 12:24:51 -0500 Original-Received: from fencepost.gnu.org ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.24) id 1B95vK-00047N-KW for emacs-devel@gnu.org; Thu, 01 Apr 2004 12:24:15 -0500 Original-To: emacs-devel@gnu.org Original-Lines: 21 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:21164 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:21164 --=-=-= I find it a nuisance that a) if a generic browser forks and detaches itself from the controlling tty, Emacs chooses to kill the process group, stopping a browser client from starting up. b) If my browser has been started by Emacs, it will get killed when Emacs is exited. Personally, I am using firefox and browse-url-generic, and so my change looks like the following: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: Start generic browser without keeping control --- browse-url.el.~1.34.~ 2004-03-10 03:16:38.000000000 +0100 +++ browse-url.el 2004-04-01 19:20:37.000000000 +0200 @@ -1352,8 +1352,8 @@ (interactive (browse-url-interactive-arg "URL: ")) (if (not browse-url-generic-program) (error "No browser defined (`browse-url-generic-program')")) - (apply 'start-process (concat browse-url-generic-program url) nil - browse-url-generic-program + (apply 'call-process browse-url-generic-program nil + 0 nil (append browse-url-generic-args (list url)))) ;;;###autoload --=-=-= Anybody mind if I check it in? People using other browsers might consider similar things. Point b) will still affect them, even if the specific Problem of starting the browser in the first place works. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel --=-=-=--