Suggested change in net/browse-url.el

From: David Kastrup <dak@gnu.org>
Subject: Suggested change in net/browse-url.el
Date: 01 Apr 2004 19:24:50 +0200	[thread overview]
Message-ID: <x565cjzk4d.fsf@lola.goethe.zz> (raw)

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]


I find it a nuisance that
a) if a generic browser forks and detaches itself from the controlling
tty, Emacs chooses to kill the process group, stopping a browser
client from starting up.

b) If my browser has been started by Emacs, it will get killed when
Emacs is exited.

Personally, I am using firefox and browse-url-generic, and so my
change looks like the following:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Start generic browser without keeping control --]
[-- Type: text/x-patch, Size: 528 bytes --]

--- browse-url.el.~1.34.~	2004-03-10 03:16:38.000000000 +0100
+++ browse-url.el	2004-04-01 19:20:37.000000000 +0200
@@ -1352,8 +1352,8 @@
   (interactive (browse-url-interactive-arg "URL: "))
   (if (not browse-url-generic-program)
     (error "No browser defined (`browse-url-generic-program')"))
-  (apply 'start-process (concat browse-url-generic-program url) nil
-	 browse-url-generic-program
+  (apply 'call-process browse-url-generic-program nil
+	 0 nil
 	 (append browse-url-generic-args (list url))))
 
 ;;;###autoload

[-- Attachment #3: Type: text/plain, Size: 256 bytes --]


Anybody mind if I check it in?  People using other browsers might
consider similar things.  Point b) will still affect them, even if the
specific Problem of starting the browser in the first place works.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

[-- Attachment #4: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel
