bug#33736: flymake test different-diagnostic-types confuses gcc and CC

bug#33736: flymake test different-diagnostic-types confuses gcc and CC

[Glenn Morris]

Package: emacs
Version: 27.0.50
Severity: minor

flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
However, what matters to the rest of the test is $CC, not gcc.
So if gcc is new enough for the test to run, but $CC is older, the test fails.

Eg on RHEL 7.6:

scl enable devtoolset-7 bash
type -ap gcc   # /opt/rh/devtoolset-7/root/usr/bin/gcc
gcc --version  # 7.3.1
make lisp/progmodes/flymake-tests  # 9 tests pass
/usr/bin/gcc --version    # 4.8.5
make lisp/progmodes/flymake-tests CC=/usr/bin/gcc
  -> different-diagnostic-types fails rather than being skipped

This happens on hydra.nixos.org, ref eg https://hydra.nixos.org/build/85857843

bug#33736: flymake test different-diagnostic-types confuses gcc and CC

[Glenn Morris]

Glenn Morris wrote:

> flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
> However, what matters to the rest of the test is $CC, not gcc.

AFAICS the tests are gcc-specific, so the Makefile should enforce that:

--- i/test/lisp/progmodes/flymake-resources/Makefile
+++ w/test/lisp/progmodes/flymake-resources/Makefile
@@ -8,6 +8,6 @@ CC_OPTS = -Wall -Wextra
 ## normally use flymake, so it seems like just avoiding the issue
 ## in this test is fine.  Set flymake-log-level to 3 to investigate.
 check-syntax:
-	GCC_COLORS= $(CC) $(CC_OPTS) ${CHK_SOURCES} || true
+	GCC_COLORS= gcc $(CC_OPTS) ${CHK_SOURCES} || true
 
 # eof

bug#33736: flymake test different-diagnostic-types confuses gcc and CC

[João Távora]

Glenn Morris <rgm@gnu.org> writes:

> Glenn Morris wrote:
>
>> flymake-test's different-diagnostic-types is skipped if "gcc" seems too old.
>> However, what matters to the rest of the test is $CC, not gcc.
>
> AFAICS the tests are gcc-specific, so the Makefile should enforce that:
>
> --- i/test/lisp/progmodes/flymake-resources/Makefile
> +++ w/test/lisp/progmodes/flymake-resources/Makefile
> @@ -8,6 +8,6 @@ CC_OPTS = -Wall -Wextra
>  ## normally use flymake, so it seems like just avoiding the issue
>  ## in this test is fine.  Set flymake-log-level to 3 to investigate.
>  check-syntax:
> -	GCC_COLORS= $(CC) $(CC_OPTS) ${CHK_SOURCES} || true
> +	GCC_COLORS= gcc $(CC_OPTS) ${CHK_SOURCES} || true
>  
>  # eof

Makes sense, thanks.

João