bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Philipp Stephani]

Evaluate something like

(process-file "/:/bin/true" "/:/dev/null")

This gives an error

(file-missing "Opening process input file" "No such file or directory" "/:/dev/null")

Other magic filenames for INFILE (such as "/ssh:localhost:/dev/null")
work as expected.  The docstring for `process-file' says that INFILE is
handled by filename handlers, so I think this should work for quoted
filenames as well.


In GNU Emacs 28.0.50 (build 91, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-05-02
Repository revision: 3768efdb926952cce85021e370c354e948b98ad0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBSYSTEMD MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND
THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: en_DK.utf8
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx
gnutls puny dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv
compile text-property-search comint ansi-color ring cl-loaddefs cl-lib
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 69335 8411)
 (symbols 48 8419 3)
 (strings 32 24381 1907)
 (string-bytes 1 789255)
 (vectors 16 15073)
 (vector-slots 8 195729 4867)
 (floats 8 26 32)
 (intervals 56 223 0)
 (buffers 992 11))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Philipp Stephani]

Am So., 2. Mai 2021 um 23:51 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
>
> Evaluate something like
>
> (process-file "/:/bin/true" "/:/dev/null")
>
> This gives an error
>
> (file-missing "Opening process input file" "No such file or directory" "/:/dev/null")
>
> Other magic filenames for INFILE (such as "/ssh:localhost:/dev/null")
> work as expected.  The docstring for `process-file' says that INFILE is
> handled by filename handlers, so I think this should work for quoted
> filenames as well.
>

Same for
(process-file "/:/bin/true" nil '((:file "/:/dev/null") "/dev/null"))

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Philipp Stephani]

Am So., 2. Mai 2021 um 23:53 Uhr schrieb Philipp Stephani
<p.stephani2@gmail.com>:
>
> Am So., 2. Mai 2021 um 23:51 Uhr schrieb Philipp Stephani
> <p.stephani2@gmail.com>:
> >
> >
> > Evaluate something like
> >
> > (process-file "/:/bin/true" "/:/dev/null")
> >
> > This gives an error
> >
> > (file-missing "Opening process input file" "No such file or directory" "/:/dev/null")
> >
> > Other magic filenames for INFILE (such as "/ssh:localhost:/dev/null")
> > work as expected.  The docstring for `process-file' says that INFILE is
> > handled by filename handlers, so I think this should work for quoted
> > filenames as well.
> >
>
> Same for
> (process-file "/:/bin/true" nil '((:file "/:/dev/null") "/dev/null"))

Other forms that I think should work, but fail:

(let ((default-directory "/:/usr/"))
  (process-file "/:/bin/true" nil '(t "/:/dev/null")))

(let ((temporary-file-directory "/:/tmp/"))
  (process-file "/:/bin/true" nil '(t "/dev/null")))

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Michael Albinus]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

Philipp Stephani <p.stephani2@gmail.com> writes:

>> > Evaluate something like
>> >
>> > (process-file "/:/bin/true" "/:/dev/null")
>> >
>> > This gives an error
>> >
>> > (file-missing "Opening process input file" "No such file or directory" "/:/dev/null")
>> >
>> > Other magic filenames for INFILE (such as "/ssh:localhost:/dev/null")
>> > work as expected.  The docstring for `process-file' says that INFILE is
>> > handled by filename handlers, so I think this should work for quoted
>> > filenames as well.
>> >
>>
>> Same for
>> (process-file "/:/bin/true" nil '((:file "/:/dev/null") "/dev/null"))
>
> Other forms that I think should work, but fail:
>
> (let ((default-directory "/:/usr/"))
>   (process-file "/:/bin/true" nil '(t "/:/dev/null")))
>
> (let ((temporary-file-directory "/:/tmp/"))
>   (process-file "/:/bin/true" nil '(t "/dev/null")))

The appended patch shall fix this, could you pls test?

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1843 bytes --]

diff --git a/lisp/files.el b/lisp/files.el
index 8e8fbac8dc..7b6e186257 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -7439,7 +7439,11 @@ file-name-non-special
         ;; might be bound to different file name handlers, we still
         ;; need this.
         (saved-file-name-handler-alist file-name-handler-alist)
-        file-name-handler-alist
+        (inhibit-file-name-handlers
+         (cons 'file-name-non-special
+               (and (eq inhibit-file-name-operation operation)
+                    inhibit-file-name-handlers)))
+        (inhibit-file-name-operation operation)
         ;; Some operations respect file name handlers in
         ;; `default-directory'.  Because core function like
         ;; `call-process' don't care about file name handlers in
diff --git a/src/callproc.c b/src/callproc.c
index 5aa2cbafb4..e44e243680 100644
--- a/src/callproc.c
+++ b/src/callproc.c
@@ -276,6 +276,9 @@ DEFUN ("call-process", Fcall_process, Scall_process, 1, MANY, 0,
   else
     infile = build_string (NULL_DEVICE);

+  /* Remove "/:" from INFILE.  */
+  infile = remove_slash_colon (infile);
+
   encoded_infile = ENCODE_FILE (infile);

   filefd = emacs_open (SSDATA (encoded_infile), O_RDONLY, 0);
@@ -439,9 +442,15 @@ call_process (ptrdiff_t nargs, Lisp_Object *args, int filefd,
   current_dir = encode_current_directory ();

   if (STRINGP (error_file))
-    error_file = ENCODE_FILE (error_file);
+    {
+      error_file = remove_slash_colon (error_file);
+      error_file = ENCODE_FILE (error_file);
+    }
   if (STRINGP (output_file))
-    output_file = ENCODE_FILE (output_file);
+    {
+      output_file = remove_slash_colon (output_file);
+      output_file = ENCODE_FILE (output_file);
+    }

   display_p = INTERACTIVE && nargs >= 4 && !NILP (args[3]);

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Philipp Stephani]

Am Mo., 3. Mai 2021 um 15:51 Uhr schrieb Michael Albinus
<michael.albinus@gmx.de>:
>
> Philipp Stephani <p.stephani2@gmail.com> writes:
>
> >> > Evaluate something like
> >> >
> >> > (process-file "/:/bin/true" "/:/dev/null")
> >> >
> >> > This gives an error
> >> >
> >> > (file-missing "Opening process input file" "No such file or directory" "/:/dev/null")
> >> >
> >> > Other magic filenames for INFILE (such as "/ssh:localhost:/dev/null")
> >> > work as expected.  The docstring for `process-file' says that INFILE is
> >> > handled by filename handlers, so I think this should work for quoted
> >> > filenames as well.
> >> >
> >>
> >> Same for
> >> (process-file "/:/bin/true" nil '((:file "/:/dev/null") "/dev/null"))
> >
> > Other forms that I think should work, but fail:
> >
> > (let ((default-directory "/:/usr/"))
> >   (process-file "/:/bin/true" nil '(t "/:/dev/null")))
> >
> > (let ((temporary-file-directory "/:/tmp/"))
> >   (process-file "/:/bin/true" nil '(t "/dev/null")))
>
> The appended patch shall fix this, could you pls test?


Yes, thanks!

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Michael Albinus]

Philipp Stephani <p.stephani2@gmail.com> writes:

>> >> > (process-file "/:/bin/true" "/:/dev/null")
>> >>
>> >> Same for
>> >> (process-file "/:/bin/true" nil '((:file "/:/dev/null") "/dev/null"))
>> >
>> > Other forms that I think should work, but fail:
>> >
>> > (let ((default-directory "/:/usr/"))
>> >   (process-file "/:/bin/true" nil '(t "/:/dev/null")))
>> >
>> > (let ((temporary-file-directory "/:/tmp/"))
>> >   (process-file "/:/bin/true" nil '(t "/dev/null")))
>>
>> The appended patch shall fix this, could you pls test?
>
>
> Yes, thanks!

Thanks for the quick confirmation! I will extend
files-tests-file-name-non-special--subprocess with your examples, and
push everything then to master.

Best regards, Michael.

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Michael Albinus]

Version: 28.1

Michael Albinus <michael.albinus@gmx.de> writes:

> Philipp Stephani <p.stephani2@gmail.com> writes:
>
>>> >> > (process-file "/:/bin/true" "/:/dev/null")
>>> >>
>>> >> Same for
>>> >> (process-file "/:/bin/true" nil '((:file "/:/dev/null") "/dev/null"))
>>> >
>>> > Other forms that I think should work, but fail:
>>> >
>>> > (let ((default-directory "/:/usr/"))
>>> >   (process-file "/:/bin/true" nil '(t "/:/dev/null")))
>>> >
>>> > (let ((temporary-file-directory "/:/tmp/"))
>>> >   (process-file "/:/bin/true" nil '(t "/dev/null")))
>>>
>>> The appended patch shall fix this, could you pls test?
>>
>>
>> Yes, thanks!
>
> Thanks for the quick confirmation! I will extend
> files-tests-file-name-non-special--subprocess with your examples, and
> push everything then to master.

Done, pushed to master. Closing the bug.

Best regards, Michael.

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Glenn Morris]

Hi, this causes a hydra.nixos test failure in tramp-test21-file-links.
Ref https://hydra.nixos.org/build/142521564

bug#48177: 28.0.50; process-file doesn't correctly handle quoted file names for INFILE

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> Hi,

Hi Glenn,

> this causes a hydra.nixos test failure in tramp-test21-file-links.
> Ref https://hydra.nixos.org/build/142521564

Yes, I've seen this as well. Shall be fixed by
f50577ea07fd85a1798cc2d41251ab1418fd802f, hopefully.

Sorry for the inconvenience, and best regards, Michael.