all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04
@ 2017-08-04 11:31 Philipp Stephani
  2017-08-05  4:08 ` Tino Calancha
  0 siblings, 1 reply; 4+ messages in thread
From: Philipp Stephani @ 2017-08-04 11:31 UTC (permalink / raw)
  To: 27946


It appears that commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks
the build on Ubuntu 14.04:

sysdep.c: In function ‘renameat_noreplace’:
sysdep.c:2695:58: error: ‘RENAME_NOREPLACE’ undeclared (first use in this function)
   return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);

Probably the #ifdef there should also include RENAME_NOREPLACE.


In GNU Emacs 26.0.50 (build 12, x86_64-pc-linux-gnu, GTK+ Version 3.10.8)
 of 2017-08-04 built on unknown
Repository revision: 5656492d04aa1a82747ff167d8063bbd7950597e
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description:	Ubuntu 14.04 LTS

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Configured using:
 'configure --enable-gcc-warnings --without-pop --with-mailutils
 --enable-checking --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
XPM JPEG TIFF GIF PNG SOUND GSETTINGS NOTIFY GNUTLS FREETYPE XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 MODULES

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date mule-util
tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932
hebrew greek romanian slovak czech european ethiopic indian cyrillic
chinese composite charscript charprop case-table epa-hook jka-cmpr-hook
help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs
button faces cus-face macroexp files text-properties overlay sha1 md5
base64 format env code-pages mule custom widget hashtable-print-readable
backquote inotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty
make-network-process emacs)

Memory information:
((conses 16 94812 7008)
 (symbols 48 20247 1)
 (miscs 40 40 120)
 (strings 32 28611 1583)
 (string-bytes 1 767158)
 (vectors 16 13992)
 (vector-slots 8 492923 8463)
 (floats 8 48 68)
 (intervals 56 223 0)
 (buffers 992 12)
 (heap 1024 42296 1101))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

Diese E-Mail ist vertraulich.  Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und löschen
Sie die E-Mail und alle Anhänge.  Vielen Dank.

This e-mail is confidential.  If you are not the right addressee please do not
forward it, please inform the sender, and please erase this e-mail including
any attachments.  Thanks.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04
  2017-08-04 11:31 bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04 Philipp Stephani
@ 2017-08-05  4:08 ` Tino Calancha
  2017-08-05  5:36   ` Paul Eggert
  0 siblings, 1 reply; 4+ messages in thread
From: Tino Calancha @ 2017-08-05  4:08 UTC (permalink / raw)
  To: 27946, Paul Eggert

Philipp Stephani <p.stephani2@gmail.com> writes:

> It appears that commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks
> the build on Ubuntu 14.04:
>
> sysdep.c: In function ‘renameat_noreplace’:
> sysdep.c:2695:58: error: ‘RENAME_NOREPLACE’ undeclared (first use in this function)
>    return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
>
> Probably the #ifdef there should also include RENAME_NOREPLACE.
I confirm i can build in Ubuntu-14.04 with this patch:

diff --git a/src/sysdep.c b/src/sysdep.c
index 22446b25d1..9eb733221e 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -2691,7 +2691,7 @@ set_file_times (int fd, const char *filename,
 int
 renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst)
 {
-#ifdef SYS_renameat2
+#if defined SYS_renameat2 && defined RENAME_NOREPLACE
   return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
 #else
   errno = ENOSYS;





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04
  2017-08-05  4:08 ` Tino Calancha
@ 2017-08-05  5:36   ` Paul Eggert
  2017-08-05  6:50     ` Tino Calancha
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2017-08-05  5:36 UTC (permalink / raw)
  To: Tino Calancha, 27946

Tino Calancha wrote:
> -#ifdef SYS_renameat2
> +#if defined SYS_renameat2 && defined RENAME_NOREPLACE

Thanks, I installed that.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04
  2017-08-05  5:36   ` Paul Eggert
@ 2017-08-05  6:50     ` Tino Calancha
  0 siblings, 0 replies; 4+ messages in thread
From: Tino Calancha @ 2017-08-05  6:50 UTC (permalink / raw)
  To: 27946-done

Paul Eggert <eggert@cs.ucla.edu> writes:

> Tino Calancha wrote:
>> -#ifdef SYS_renameat2
>> +#if defined SYS_renameat2 && defined RENAME_NOREPLACE
>
> Thanks, I installed that.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-08-05  6:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-04 11:31 bug#27946: 26.0.50; Commit 1f9f514e7c2ba41b0954d0141f99652f6a53a107 breaks the build on Ubuntu 14.04 Philipp Stephani
2017-08-05  4:08 ` Tino Calancha
2017-08-05  5:36   ` Paul Eggert
2017-08-05  6:50     ` Tino Calancha

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.