From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philipp Stephani Newsgroups: gmane.emacs.bugs Subject: bug#53269: Fix customization choices for tab-first-completion Date: Fri, 14 Jan 2022 20:51:43 +0100 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38660"; mail-complaints-to="usenet@ciao.gmane.io" To: 53269@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 14 20:52:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8Scp-0009tJ-Lz for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 20:52:39 +0100 Original-Received: from localhost ([::1]:57284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n8Sco-0002rL-GX for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 14 Jan 2022 14:52:38 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41352) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8ScE-0002pX-Tm for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 14:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45309) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8ScE-0006yI-Kl for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 14:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n8ScE-0003Lh-L0 for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 14:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philipp Stephani Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 14 Jan 2022 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 53269 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.164218991512856 (code B ref -1); Fri, 14 Jan 2022 19:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 14 Jan 2022 19:51:55 +0000 Original-Received: from localhost ([127.0.0.1]:38212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Sc7-0003LI-ES for submit@debbugs.gnu.org; Fri, 14 Jan 2022 14:51:55 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58938) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n8Sc4-0003L9-Ll for submit@debbugs.gnu.org; Fri, 14 Jan 2022 14:51:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n8Sc4-0002p6-EK for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 14:51:52 -0500 Original-Received: from [2a00:1450:4864:20::32e] (port=52102 helo=mail-wm1-x32e.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n8Sc2-0006xF-Q5 for bug-gnu-emacs@gnu.org; Fri, 14 Jan 2022 14:51:52 -0500 Original-Received: by mail-wm1-x32e.google.com with SMTP id c2so2507433wml.1 for ; Fri, 14 Jan 2022 11:51:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version; bh=GsnwQbc1kQ0JF4IxuZE/LnB0pkMLjXNZC8TbjdezGvM=; b=Cenb0ixAtQQAZ6j/RzHnSl3QORUlrocZTSxBYzX6CCHgQxIWouEGTKu/+Jv0UciZAW EZ30/1Hs0UwRc8jUBxkjaM4LqJCcmMQTXC3U9qqFYIqgf8uli79WZN4v3aGpTN62uCv3 Y0T3N+MbR2CTKozaYtrjf9yzeVDawDDYnj5YazcbWIUSmRwDQeh20oumIJpvmSc2LUms 002tgpdO3wcu+W1FJMwKxoQrl/CgcFFTUBB0QThLmm7+hG6wmOnX41eAj5qcg7StQi4z r+yvpMRUvi36u1LfKI7rispotQIU47vIJXBaNXV7KtJAYLEcGviNNvFRhuXNl300Yj0c NuYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=GsnwQbc1kQ0JF4IxuZE/LnB0pkMLjXNZC8TbjdezGvM=; b=Tt9Bp5z+Qfr+3fcixZ6QAAhfbHUymYOowkSN0fCCYUQh3+ynrtKrgcobm1l4/tYoUF Vy54v5x/QIe9qH3fVuFVguY5sMkDoCilf1Ka9X2Tes3rnb4Cd7ayIPNykgL6Y3TJPwYU 56Fa2Ifvp1qfBt7TzkN/9YFXcJkWUQkf7Sq9hQOe8h8s3EB4uiTF5QJM6pmNBq71N8Cl 5w40XRekKy7IaVR2PdAt29dTBe72O37ihZXqUfnUNrlDgDVw6O5dt999ZfiULarptC7/ dBNuicftL0ioYHjjNoBJCuTkyNnBIbz4j1w5DoPhT6cSH8WtaYYo5fy8aUDYurfp4fSa +zCg== X-Gm-Message-State: AOAM530qimVs+86Yy7YSW+wP725/yjplCSb7STxfgUAEy3oEA47XYJ7W LwOzn7KTg3qUka5jLwRxvHhAv+ZP9mc= X-Google-Smtp-Source: ABdhPJwLsx7wOPfR5UZC5ou7a5+tXPjhhQH1XvIZU2dY9hp6JM7zBdnC4s4t6Ue3PJJ3S6XVGsh6Bw== X-Received: by 2002:adf:f102:: with SMTP id r2mr7825570wro.480.1642189908134; Fri, 14 Jan 2022 11:51:48 -0800 (PST) Original-Received: from phst ([2a02:2455:2a4:dc00:3205:4b5f:db87:c7f2]) by smtp.gmail.com with ESMTPSA id c12sm6240315wrr.7.2022.01.14.11.51.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jan 2022 11:51:47 -0800 (PST) X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::32e (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=p.stephani2@gmail.com; helo=mail-wm1-x32e.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224233 Archived-At: --=-=-= Content-Type: text/plain Tags: patch The customization choices for tab-first-completion are double-quoted. The attached patch fixes this. Can I install it on the release branch? In GNU Emacs 28.0.91 (build 4, x86_64-pc-linux-gnu, GTK+ Version 3.24.30, cairo version 1.16.0) of 2022-01-13 Repository revision: 34ca4ff9a52d38250f70f578fd045490b4eef4f9 Repository branch: emacs-28 Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Debian GNU/Linux rodete Configured using: 'configure --enable-gcc-warnings=warn-only --enable-gtk-deprecation-warnings --without-pop --with-mailutils --enable-checking=all --enable-check-lisp-object-type --with-modules 'CFLAGS=-O0 -ggdb3'' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-lisp-indent.el-tab-first-completion-Fix-incorrect-ch.patch >From 364656460f7c43bd46289a7188499acd9452440c Mon Sep 17 00:00:00 2001 From: Philipp Stephani Date: Fri, 14 Jan 2022 20:49:35 +0100 Subject: [PATCH] * lisp/indent.el (tab-first-completion): Fix incorrect choices. --- lisp/indent.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/indent.el b/lisp/indent.el index f0c11ad0df..48e5b309e4 100644 --- a/lisp/indent.el +++ b/lisp/indent.el @@ -77,10 +77,11 @@ tab-first-completion :group 'indent :type '(choice (const :tag "Always complete" nil) - (const :tag "Unless at the end of a line" 'eol) - (const :tag "Unless looking at a word" 'word) - (const :tag "Unless at a word or parenthesis" 'word-or-paren) - (const :tag "Unless at a word, parenthesis, or punctuation." 'word-or-paren-or-punct)) + (const :tag "Unless at the end of a line" eol) + (const :tag "Unless looking at a word" word) + (const :tag "Unless at a word or parenthesis" word-or-paren) + (const :tag "Unless at a word, parenthesis, or punctuation." + word-or-paren-or-punct)) :version "28.1") (defvar indent-line-ignored-functions '(indent-relative -- 2.34.1.703.g22d0c6ccf7-goog --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable --=20 Google Germany GmbH Erika-Mann-Stra=C3=9Fe 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese f=C3=A4lschlicherweise erhal= ten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, l=C3=B6sche= n Sie alle Kopien und Anh=C3=A4nge davon und lassen Sie mich bitte wissen, dass d= ie E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don=E2=80=99t forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. --=-=-=--